Replace foreach with range-based for loop

guilyx · guilyx · commit 883ec291d453 · 2025-12-25T18:03:48.000+04:00
diff --git a/src/TopicPublisherROS2/publisher_ros2.cpp b/src/TopicPublisherROS2/publisher_ros2.cpp
@@ -172,8 +172,7 @@ void TopicPublisherROS2::filterDialog()
               {
                 dialog->ui()->listTopics->selectRow(row);
               }
-            }
-          });
+            } });
   connect(dialog->ui()->pushButtonDeselect, &QPushButton::pressed, dialog->ui()->listTopics,
           &QAbstractItemView::clearSelection);
 
@@ -189,7 +188,7 @@ void TopicPublisherROS2::filterDialog()
       _topics_to_publish.insert({info.topic_name, false});
     }
 
-    foreach (QModelIndex index, selected_indexes)
+    for (const QModelIndex &index : selected_indexes)
     {
       if (index.column() == 0)
       {

Original file line number	Diff line number	Diff line change
`@@ -172,8 +172,7 @@ void TopicPublisherROS2::filterDialog()`
`172`	`172`	`{`
`173`	`173`	`dialog->ui()->listTopics->selectRow(row);`
`174`	`174`	`}`
`175`		`- }`
`176`		`- });`
	`175`	`+ } });`
`177`	`176`	`connect(dialog->ui()->pushButtonDeselect, &QPushButton::pressed, dialog->ui()->listTopics,`
`178`	`177`	`&QAbstractItemView::clearSelection);`
`179`	`178`
`@@ -189,7 +188,7 @@ void TopicPublisherROS2::filterDialog()`
`189`	`188`	`_topics_to_publish.insert({info.topic_name, false});`
`190`	`189`	`}`
`191`	`190`
`192`		`- foreach (QModelIndex index, selected_indexes)`
	`191`	`+ for (const QModelIndex &index : selected_indexes)`
`193`	`192`	`{`
`194`	`193`	`if (index.column() == 0)`
`195`	`194`	`{`