Replace foreach with range-based for loop

guilyx · guilyx · commit ec5fcf94da4b · 2025-11-14T00:59:05.000+04:00
diff --git a/src/TopicPublisherROS2/publisher_ros2.cpp b/src/TopicPublisherROS2/publisher_ros2.cpp
@@ -174,8 +174,7 @@ void TopicPublisherROS2::filterDialog()
               {
                 dialog->ui()->listTopics->selectRow(row);
               }
-            }
-          });
+            } });
   connect(dialog->ui()->pushButtonDeselect, &QPushButton::pressed, dialog->ui()->listTopics,
           &QAbstractItemView::clearSelection);
 
@@ -191,7 +190,7 @@ void TopicPublisherROS2::filterDialog()
       _topics_to_publish.insert({info.topic_name, false});
     }
 
-    foreach (QModelIndex index, selected_indexes)
+    for (const QModelIndex &index : selected_indexes)
     {
       if (index.column() == 0)
       {

Original file line number	Diff line number	Diff line change
`@@ -174,8 +174,7 @@ void TopicPublisherROS2::filterDialog()`
`174`	`174`	`{`
`175`	`175`	`dialog->ui()->listTopics->selectRow(row);`
`176`	`176`	`}`
`177`		`- }`
`178`		`- });`
	`177`	`+ } });`
`179`	`178`	`connect(dialog->ui()->pushButtonDeselect, &QPushButton::pressed, dialog->ui()->listTopics,`
`180`	`179`	`&QAbstractItemView::clearSelection);`
`181`	`180`
`@@ -191,7 +190,7 @@ void TopicPublisherROS2::filterDialog()`
`191`	`190`	`_topics_to_publish.insert({info.topic_name, false});`
`192`	`191`	`}`
`193`	`192`
`194`		`- foreach (QModelIndex index, selected_indexes)`
	`193`	`+ for (const QModelIndex &index : selected_indexes)`
`195`	`194`	`{`
`196`	`195`	`if (index.column() == 0)`
`197`	`196`	`{`