Skip to content

Commit e936b85

Browse files
author
Davide Faconti
committed
fix: drop remaining magic_enum SDK dependency
1 parent b6ac06c commit e936b85

3 files changed

Lines changed: 2 additions & 7 deletions

File tree

cmake/PlotJugglerSDKConfig.cmake.in

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,6 @@ if(NOT PlotJugglerSDK_FIND_COMPONENTS)
77
set(PlotJugglerSDK_FIND_COMPONENTS DataSource)
88
endif()
99

10-
# pj_base carries the SDK builtin-object vocabulary and publicly depends on
11-
# magic_enum for enum/string helpers, so the exported targets need it before
12-
# they are loaded.
13-
find_dependency(magic_enum)
14-
1510
# Include the exported targets (defines PlotJugglerSDK::DataSource, etc.).
1611
include("${CMAKE_CURRENT_LIST_DIR}/PlotJugglerSDKTargets.cmake")
1712

pj_base/include/pj_base/builtin/DepthImage.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ namespace sdk {
4444
/// R: rectification rotation. Identity for rectified images.
4545
/// P: projection matrix [K | 0_3] (3×4) for rectified images.
4646
///
47-
/// Helpers in pj_base/builtin/depth_image_utils.h produce R
47+
/// Helpers in pj_base/builtin/depth_image_utils.hpp produce R
4848
/// and P when a consumer wants them precomputed.
4949
///
5050
/// `anchor` keeps the underlying buffer alive — the producer may have

pj_base/include/pj_base/plugin_data_api.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ extern "C" {
3838
* token).
3939
*
4040
* Contract for plugin authors: the symbol is emitted automatically at file
41-
* scope by `pj_base/plugin_abi_export.h`, which is transitively included by
41+
* scope by `pj_base/plugin_abi_export.hpp`, which is transitively included by
4242
* every family SDK header (data_source_plugin_base.hpp, dialog_plugin_base.hpp,
4343
* etc.). Weak linkage lets multiple TUs in the same DSO each emit a definition
4444
* and have the linker fold them into one COMDAT entry — so co-resident DSOs

0 commit comments

Comments
 (0)