chore: detach pj_ported_plugins from build, document main as PR target#102
Closed
facontidavide wants to merge 1 commit into
Closed
chore: detach pj_ported_plugins from build, document main as PR target#102facontidavide wants to merge 1 commit into
facontidavide wants to merge 1 commit into
Conversation
The pj_ported_plugins collection lives in its own upstream repository (pj-official-plugins) and is no longer maintained inside this tree. Remove the conditional add_subdirectory hook, the unused PJ_BUILD_PORTED_PLUGINS option, and the build.sh loop that installed its Conan deps into the same output folder. Also drop the stale toolchain assignment in conanfile.py that pinned the (now-removed) PJ_BUILD_PORTED_PLUGINS cache var to False — CMake no longer defines the option, so the assignment had no effect and would produce an "unused variable" warning on the next reconfigure. Add a Branch Convention section to CLAUDE.md documenting that PRs target main (origin/development was deleted; gh repo view --json defaultBranchRef returns main) and noting that pj_ported_plugins is not part of this tree. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add_subdirectory(pj_ported_plugins)hook, the unusedPJ_BUILD_PORTED_PLUGINSCMake option, and thebuild.shloop that ranconan installinsidepj_ported_plugins/. The collection is maintained upstream aspj-official-plugins; no in-tree subdirectory is expected.tc.cache_variables["PJ_BUILD_PORTED_PLUGINS"] = Falseline inconanfile.py— CMake no longer defines the option, so this assignment was a no-op that would produce an "unused variable" warning on the next reconfigure.CLAUDE.md: PRs targetmain(origin/development was deleted upstream;gh repo view --json defaultBranchRefreturnsmain). Also note thatpj_ported_plugins/is external and not part of this build.Test plan
cmake -B buildreconfigures cleanly with noPJ_BUILD_PORTED_PLUGINSwarningcmake --build build) passes with-Wall -Wextra -Werror🤖 Generated with Claude Code