feat(pj_base)!: carry frame_id through the canonical Image schema#117
Merged
Conversation
Image was the only canonical builtin lacking frame_id: a producer could not tell a consumer which CameraInfo (calibration / native resolution / rectification) an image belongs to. Every sibling codec already serializes frame_id; Image silently dropped it on any serialized path. - Image.proto: append field 10 (string frame_id). - image_codec: serialize/deserialize frame_id. - image_codec_test: populated round-trip + empty default. The wire change alone is forward/backward compatible (an old reader skips the unknown field). The break is the struct: sdk::Image gains a member, so its layout changes, and Image crosses the plugin/host boundary by value inside BuiltinObject (std::any) -- an old-built plugin and a new host then disagree on its layout. That is an ABI break => MAJOR per the SDK versioning policy; the first break since pre-1.0, so bump 0.6.0 -> 1.0.0. baseline.abi is unchanged: a header struct field exports no ELF symbols. BREAKING CHANGE: plotjuggler_sdk 1.0.0; consumers pin [>=1.0.0 <2.0.0]. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Alvvalencia
force-pushed
the
alvvm/image-frame-id
branch
from
4bb4d29 to
bbbc0fe
Compare
Contributor
|
@copilot remove the version number increment, I will do it in a separate PR |
Contributor
|
@facontidavide I've opened a new pull request, #118, to work on those changes. Once the pull request is ready, I'll request review from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imagewas the only canonical builtin not carryingframe_id: a producer could not tell aconsumer which
CameraInfo(calibration / native resolution / rectification) an image belongs to,nor place it in 3D via the TF tree. Every sibling codec already serializes
frame_id;Imagesilently dropped it on any serialized path.
Change
Image.proto: append field 10 (string frame_id).image_codec: serialize / deserializeframe_id.image_codec_test: populated round-trip + empty default.Compatibility / version
The wire change alone is forward/backward compatible (an old reader skips the unknown field). The
break is the struct:
sdk::Imagegains a member, andImagecrosses the plugin↔host boundaryby value inside
BuiltinObject(std::any), so an old-built plugin and a new host disagree onlayout. Per the SDK versioning policy that is an ABI break → MAJOR, and since it is the first
break leaving pre-1.0, it bumps 0.6.0 → 1.0.0.
abi/baseline.abiis unchanged (a header structfield exports no ELF symbols). Consumers pin
[>=1.0.0 <2.0.0].