performance and color#102
Merged
rbergen merged 7 commits intoJun 21, 2026
Merged
Conversation
- Refactored HSV2RGB to use hsv2rgb_rainbow for better speed and color accuracy. - Optimized blendWith using lerp8. - Added memcpy fast-path to PixelsToByteArray to reduce CPU overhead. - Defaulted logging level to debug.
Collaborator
|
See comment on #101. |
Merged
rbergen
added a commit
that referenced
this pull request
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes color issues observed with a new custom effect.
While I was in the file, I noticed some tiperformance
optimizations left on the floor, like loop unswitching.
I checked all the effects on my strip with --live-view
and real hardware and they all seem fine.
(Done in partnership with Gemini.)