webserver enhancements#104
Conversation
…ON headers - Switched to recursive_mutex to prevent deadlocks during complex API callback chains. - Added support for serving static UI assets from the 'static/' directory. - Implemented automated 'Content-Type: application/json' headers for all API routes. - Simplified locking logic across all handlers.
|
See comment on #101. |
|
CI still fails on this one, and I believe it has a genuine complaint: Copying secrets.h.example to secrets.h...
Compiling main.cpp...
In file included from main.cpp:33:
./webserver.h:317:54: error: too many arguments to function call, expected single argument 'effect', have 2 arguments
317 | effectsManager.AddEffect(effect, schedule);
| ~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~
./interfaces.h:129:18: note: 'AddEffect' declared here
129 | virtual void AddEffect(shared_ptr<ILEDEffect> effect) = 0;
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated. |
|
That was fixed three months ago, back in 2178d1a856dabb32371b1f94513b485cefc5e41a ndscpp make -C tests && tests/tests [----------] Global test environment tear-down Reconciled via Gemini...because my attention span isn't this long. This is unrealistically far back in history, but I'm committed to make this code better. ✦ I have resolved the branch issues, synced with the remote, and pushed the fix Summary of Actions:
The PR #104 |
|
I'm closing this due to massive drift in main in the key target (webserver.h) due to #100. I'll note for the record that that PR was opened before this one, so the PRs were processed in the logical order. |
Fixed lockups under load.
Made Content-Type consistent for API vs. static page requests.
Don't recompile app if only config files changed.