Skip to content

Newbeat#858

Merged
rbergen merged 4 commits intomainfrom
newbeat
Apr 30, 2026
Merged

Newbeat#858
rbergen merged 4 commits intomainfrom
newbeat

Conversation

@davepl
Copy link
Copy Markdown
Contributor

@davepl davepl commented Apr 26, 2026

Description

Adds actually useful/accurate beat detection. Updates the Stars effect to use it. Adds a blue "near miss" and red "beat detect" in the center of the VU meter. Not permanent, necessarily.

  • I read the contribution guidelines in CONTRIBUTING.md.
  • I understand the BlinkenPerBit metric, and maximized it in this PR.
  • I selected main as the target branch.
  • All code herein is subjected to the license terms in COPYING.txt.

@rbergen
Copy link
Copy Markdown
Collaborator

rbergen commented Apr 27, 2026

This PR includes the changes proposed in #857 - which is still in progress of being reviewed - and as such builds on that one.

I'll therefore hold on reviewing this PR until #857 is either merged or closed, so we can focus on the delta between the two.

This was referenced Apr 28, 2026
Copy link
Copy Markdown
Collaborator

@rbergen rbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, explicitly also applying to the changes originally introduced in #857.

@rbergen rbergen merged commit a58e4c0 into main Apr 30, 2026
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants