Verson 2.4#18
Conversation
Updated version number from 2.21 to 2.24 and adjusted related documentation sections to reflect the new version. Corrected references to critical bug fixes and features in the README.
Refactor PowerShell script checks and download process to improve error handling and support for VPN/proxy environments.
Added images and badges to enhance README visibility.
Updated README to reflect changes in version 2.4, including bug fixes, technical changes, and improvements in network testing.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7344d27d6a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ($prevCallback -ne $null) { | ||
| try { [System.Net.ServicePointManager]::ServerCertificateValidationCallback = $prevCallback } catch {} | ||
| $prevCallback = $null |
There was a problem hiding this comment.
If a download attempt fails while the prior ServerCertificateValidationCallback is null (the default), the if ($prevCallback -ne $null) guard skips restoration and leaves the global callback set to { $true }. That means later HTTPS calls in the same PowerShell process run without certificate validation, and subsequent retries can keep that insecure state. The failure path should always restore the callback, including restoring it to null.
Useful? React with 👍 / 👎.
| powershell -NoProfile -ExecutionPolicy Bypass -Command "try { . ""%SCRIPT_PS1%""; Test-ToolVerification } catch { Write-Error $_; exit 1 }" | ||
| echo. | ||
| if "%VERIFY_CODE%"=="0" ( | ||
| echo Verification complete. All tools validated successfully. | ||
| ) else ( | ||
| if "%VERIFY_CODE%"=="2" ( | ||
| echo [WARNING] Verification completed with issues detected. Review output above. | ||
| echo Use Menu Option 5 to re-download the Sysinternals Suite. | ||
| ) else ( | ||
| echo [ERROR] Verification encountered an issue. Review output above. | ||
| ) | ||
| ) | ||
| echo Verification complete. Review output above. | ||
| echo If issues were found, use Menu Option 5 to re-download. |
There was a problem hiding this comment.
The VERIFY path now prints a completion message unconditionally after invoking PowerShell, so users can see "Verification complete" even when the command failed (e.g., dot-sourcing error or exception in Test-ToolVerification). Since errorlevel is no longer evaluated, failed verification runs can be misreported as successful and lead to incorrect troubleshooting actions.
Useful? React with 👍 / 👎.
1 participant
Summary
Explain what this PR changes and why.
Type of change
Checklist
Screenshots / Demos
If applicable.
Breaking changes
Describe any breaking changes and migration steps.