Merge pull request #163 from PoCInnovation/150-ghost-vm-rows-in-db

fix(backend): remove ghost vm rows from db

Author: lg-epitech

backend/app/orm/event.py

@@ -36,5 +36,11 @@ class EventParticipantORM(SQLModel, table=True):
         )
     )
     participant_name: str
-    vm_id: uuid.UUID = Field(foreign_key="vms.id")
+    vm_id: uuid.UUID = Field(
+        sa_column=Column(
+            UUID(as_uuid=True),
+            ForeignKey("vms.id", ondelete="CASCADE"),
+            nullable=False,
+        )
+    )
     created_at: datetime = Field(default_factory=datetime.utcnow)

backend/app/services/vm_service.py

@@ -14,6 +14,7 @@
 from sqlmodel import Session, select, delete
 from app.orm.vm import VmORM
 from app.orm.vm_credential import VmCredentialORM
+from app.orm.event import EventParticipantORM
 from app.orm.slave import SlaveORM
 from fastapi import status, HTTPException
 from app.utils.vm import get_vm_ip
@@ -277,6 +278,11 @@ def remove(self):
             rmtree(vm_dir)
 
         with Session(engine) as session:
+            session.exec(
+                delete(EventParticipantORM).where(
+                    EventParticipantORM.vm_id == self.id
+                )
+            )
             session.exec(
                 delete(VmCredentialORM).where(
                     VmCredentialORM.vm_id == self.id
@@ -564,6 +570,11 @@ def remove_vm(vm_id: str):
             slave_delete_vm(slave, vm_id)
             # Remove the reference from master DB
             with Session(engine) as session:
+                session.exec(
+                    delete(EventParticipantORM).where(
+                        EventParticipantORM.vm_id == uuid.UUID(vm_id)
+                    )
+                )
                 session.exec(
                     delete(VmCredentialORM).where(
                         VmCredentialORM.vm_id == uuid.UUID(vm_id)