4주차 과제#4
Open
Jokwanhee wants to merge 3 commits into
Open
Conversation
Jokwanhee
requested review from
chattymin,
haeti-dev,
kangyuri1114 and
stellar-halo
haeti-dev
approved these changes
Apr 16, 2024
haeti-dev
left a comment
haeti-dev
left a comment
There was a problem hiding this comment.
어우 빌드 로직 모듈 만드느라 고생하셨습니다
고양이 불러오기 치명적이네요 ㅎㄷㄷ
Comment on lines
+35
to
+41
| implementation(libs.androidx.lifecycle.runtime.compose) | ||
| implementation(libs.hilt.navigation.compose) | ||
| implementation(libs.androidx.navigation.compose) | ||
| testImplementation(libs.junit4) | ||
| testImplementation(libs.orbit.test) | ||
| androidTestImplementation(libs.androidx.test.ext) | ||
| androidTestImplementation(libs.androidx.test.espresso) |
| modifier = modifier.fillMaxSize() | ||
| ) { | ||
| Text( | ||
| text = "고양이 보실?", |
| modifier = Modifier.fillMaxWidth() | ||
| ) | ||
| Spacer(modifier = Modifier.height(10.dp)) | ||
| LazyVerticalStaggeredGrid( |
chattymin
approved these changes
Apr 23, 2024
Comment on lines
+27
to
+30
| val state by homeViewModel.loginData.collectAsState() | ||
| val loginData = it.savedStateHandle.get<LoginData>("loginData") | ||
| if (loginData != null) { | ||
| homeViewModel.updateUserData(loginData) |
Member
There was a problem hiding this comment.
여기선 composableActivityViewModel()을 사용하고, 윗부분에선 hiltViewModel을 사용하셨는데 어떤 이유로 차이를 준건가요?
Collaborator
Author
There was a problem hiding this comment.
제가 hiltViewModel을 잘 모르는데, 사용되면 lifecycle owner가 composition이 아니라 activity를 따르는건가용..? 그렇다면 제가 공부를 더 해야겠네요..
단순한게 Home Composable에서 composableActivityViewModel 을 사용한 이유는 bottom navi로 이동 되어도 데이터를 보존하기 위함 하나입니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
이슈
시연 영상
Android.Emulator.-.Pixel_4_API_34_5554.2024-04-15.21-19-32.mp4
알립니다!
그 전 섭팟장님해주신 api 사용하려고 하니깐 안되어서 로그인 쪽 api는 적용하지 못했습니다!_! 그래서 따로 open api 사용해서 고양이들 불러와봤습니다!
추가적으로 버전 카탈로그 적용해보면서 build-logic으로 플러그인 클래스를 만들어봤씁니다!