Skip to content

@Flow.model decorator to convert function into CallableModel#171

Open
NeejWeej wants to merge 48 commits intomainfrom
nk/auto_deps_auto_callable_model
Open

@Flow.model decorator to convert function into CallableModel#171
NeejWeej wants to merge 48 commits intomainfrom
nk/auto_deps_auto_callable_model

Conversation

@NeejWeej
Copy link
Copy Markdown
Collaborator

@NeejWeej NeejWeej commented Jan 5, 2026

No description provided.

Nijat Khanbabayev added 6 commits December 31, 2025 03:56
Add ability to define dynamic context from kwargs
de87bb2 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Merge branch 'nk/local_model_context_registration' into nk/add_dynami…
c16613f 
…c_context_v2
Merge branch 'nk/local_model_context_registration' into nk/add_dynami…
f89ff9f 
…c_context_v2

Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Merge branch 'nk/local_model_context_registration' into nk/add_dynami…
66b0e4e 
…c_context_v2
Merge branch 'nk/local_model_context_registration' into nk/add_dynami…
6f71e38 
…c_context_v2
Remove dynamic context, add option to Flow.call
95119e3 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
@NeejWeej NeejWeej changed the base branch from main to nk/add_dynamic_context_v2 January 5, 2026 00:22
@NeejWeej NeejWeej force-pushed the nk/auto_deps_auto_callable_model branch from e93a9c4 to b7fe3d9 Compare January 5, 2026 01:30
Add @Flow.model decorator, new annotation that pulls from deps
989e278 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
@NeejWeej NeejWeej force-pushed the nk/auto_deps_auto_callable_model branch from b7fe3d9 to 989e278 Compare January 5, 2026 01:44
Nijat Khanbabayev added 4 commits January 4, 2026 21:09
Inside CallableModel, force calling resolve on DepOf to not do hacky …
970b4ab 
…switching out attributes at runtime

Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
High level design doc
2696fce 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Add extra stuff, need clean-up
d180f35 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Merge branch 'main' into nk/auto_deps_auto_callable_model
504dd96 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
@NeejWeej NeejWeej force-pushed the nk/auto_deps_auto_callable_model branch from 167e462 to 504dd96 Compare March 16, 2026 22:29
Lint fixes
9495915 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 16, 2026 •
edited
Loading

Test Results

863 tests  +212   861 ✅ +212   2m 8s ⏱️ +25s
  1 suites ±  0     2 💤 ±  0 
  1 files   ±  0     0 ❌ ±  0 

Results for commit 7917433. ± Comparison against base commit e2ef462.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 91.34140% with 315 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.74%. Comparing base (e2ef462) to head (7917433).

Files with missing lines Patch % Lines
ccflow/flow_model.py 83.86% 97 Missing and 66 partials ⚠️
ccflow/tests/test_flow_model.py 94.76% 82 Missing and 2 partials ⚠️
ccflow/_flow_model_binding.py 89.81% 21 Missing and 12 partials ⚠️
ccflow/tests/test_callable.py 90.56% 15 Missing ⚠️
ccflow/context.py 70.27% 7 Missing and 4 partials ⚠️
ccflow/tests/test_flow_context.py 98.07% 4 Missing ⚠️
ccflow/callable.py 93.33% 1 Missing and 1 partial ⚠️
ccflow/evaluators/common.py 97.70% 2 Missing ⚠️
ccflow/tests/evaluators/test_common.py 98.36% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   96.00%   94.74%   -1.26%     
==========================================
  Files         140      145       +5     
  Lines        9839    13458    +3619     
  Branches      568      870     +302     
==========================================
+ Hits         9446    12751    +3305     
- Misses        275      505     +230     
- Partials      118      202      +84

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NeejWeej NeejWeej changed the base branch from nk/add_dynamic_context_v2 to main March 17, 2026 09:06
Nijat Khanbabayev added 10 commits March 17, 2026 05:36
Flow.model cleanup
765299d 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Update docs for @Flow.model
097ae62 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Clean up, ty check @Flow.model, add test
3d26896 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Clean up more, make repr nicer for BoundModel
0c274a1 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Small bug fixes for @Flow.model
9c7bc7d 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Temp progress for cleaning up
5569ed0 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Further clean-up
20612e2 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Update docs and small flow_model changes
587b26f 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Add more examples
517f45e 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
More test coverage
324fc4e 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
@NeejWeej NeejWeej marked this pull request as ready for review April 6, 2026 20:35
Nijat Khanbabayev added 6 commits April 9, 2026 13:50
Merge branch 'main' into nk/auto_deps_auto_callable_model
7b865b1 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Add checks to not allow positional args, or **kwargs in @Flow.model d…
2b3e1c9 
…ecorated functions

Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Handle normal bound arguments and context conflict seamlessly
c872d6b 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Simplify code
a3deba3 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Merge branch 'main' into nk/auto_deps_auto_callable_model
1bfcaed 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Merge branch 'main' into nk/auto_deps_auto_callable_model
25384da 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
@NeejWeej NeejWeej changed the title Nk/auto deps auto callable model @Flow.model decorator to convert functions into CallableModel's Apr 13, 2026
Merge branch 'main' into nk/auto_deps_auto_callable_model
6a5020a 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
@NeejWeej NeejWeej changed the title @Flow.model decorator to convert functions into CallableModel's @Flow.model decorator to convert function into CallableModel Apr 13, 2026
Nijat Khanbabayev added 4 commits April 13, 2026 12:08
Handle pickling of unset singleton
c479bb5 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Dont use marshal, add rountrip serialization tests
6f4e8bf 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Cement api for contextual transforms
5e32c85 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
Allow .compute to take _options
f3886fe 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
@NeejWeej NeejWeej force-pushed the nk/auto_deps_auto_callable_model branch 2 times, most recently from d22ffc4 to 0121702 Compare April 16, 2026 18:35
Simplify Flow.model code, update docs
22c86f1 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
@NeejWeej NeejWeej force-pushed the nk/auto_deps_auto_callable_model branch from 0121702 to 22c86f1 Compare April 16, 2026 18:39
Merge branch 'main' into nk/auto_deps_auto_callable_model
1bc0a86 
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
@NeejWeej NeejWeej force-pushed the nk/auto_deps_auto_callable_model branch from b6f38cf to 1bc0a86 Compare April 17, 2026 07:31
@ptomecek
Copy link
Copy Markdown
Collaborator

ptomecek commented Apr 24, 2026

Is this ready for another (final) review?

@NeejWeej
Copy link
Copy Markdown
Collaborator Author

NeejWeej commented Apr 24, 2026

Is this ready for another (final) review?

Not yet, I'm planning on doing another pass myself, first, then I'll leave a comment here asking for a final review.

NeejWeej added 6 commits April 25, 2026 22:17
@NeejWeej
Add internal helper module for binding
c07aa79 
Signed-off-by: Nijat K <nijat.khanbabayev@gmail.com>
@NeejWeej
Make sure context transform can be defined locally and serializes
136fe3f 
Signed-off-by: Nijat K <nijat.khanbabayev@gmail.com>
@NeejWeej
Reduce effect on existing good code with auto_context
2cb3192 
Signed-off-by: Nijat K <nijat.khanbabayev@gmail.com>
@NeejWeej
Merge branch 'main' into nk/auto_deps_auto_callable_model
2b1ca09 
Signed-off-by: Nijat K <nijat.khanbabayev@gmail.com>
@NeejWeej
Simplify logic more
91cd5d4 
Signed-off-by: Nijat K <nijat.khanbabayev@gmail.com>
@NeejWeej
Simplify semantic context generation for @Flow.model
7917433 
Signed-off-by: Nijat K <nijat.khanbabayev@gmail.com>
@NeejWeej NeejWeej force-pushed the nk/auto_deps_auto_callable_model branch from 128a6b4 to 7917433 Compare April 28, 2026 08:32
@NeejWeej
Copy link
Copy Markdown
Collaborator Author

NeejWeej commented Apr 28, 2026

@ptomecek This is ready for another review. I created an internal module to keep the shared binding logic used for auto_context on normal CallableModels and @Flow.model generated models, and edited the PR to minimize touching existing, working code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feussy feussy Awaiting requested review from feussy feussy is a code owner

@hintse hintse Awaiting requested review from hintse hintse is a code owner

@timkpaine timkpaine Awaiting requested review from timkpaine timkpaine is a code owner

@ptomecek ptomecek Awaiting requested review from ptomecek ptomecek is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NeejWeej @ptomecek