Changes to tools (#5605)

* Move IO tools to tools folder.

* Made all dependencies optional and build tools if requirements are met.

* Fix opnni_viewer_simple

* Satisfy clang-tidy

* Make io hard-dependency.

* Link pcl_common to pcl_io_ply.

* Fix includes from pcl_common.

* Remove check for pcl_io target.

Move tools under if target pcl_recognition.
Move tools under other if, having nested if instead of multiple conditions in ifs.

* More reorganizing due to dependencies.

* Fixup remove boost.

* Fix missing TARGET keyword

Co-authored-by: Markus Vieth <39675748+mvieth@users.noreply.github.com>

---------

Co-authored-by: Markus Vieth <39675748+mvieth@users.noreply.github.com>

Author: larshg

common/CMakeLists.txt

@@ -172,9 +172,13 @@ set(kissfft_srcs
 )
 
 set(LIB_NAME "pcl_${SUBSYS_NAME}")
-include_directories("${CMAKE_CURRENT_SOURCE_DIR}/include")
 PCL_ADD_LIBRARY(${LIB_NAME} COMPONENT ${SUBSYS_NAME} SOURCES ${srcs} ${kissfft_srcs} ${incs} ${common_incs} ${impl_incs} ${tools_incs} ${kissfft_incs} ${common_incs_impl} ${range_image_incs} ${range_image_incs_impl})
 
+target_include_directories(${LIB_NAME} PUBLIC
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+  $<INSTALL_INTERFACE:include> 
+)
+
 target_link_libraries(${LIB_NAME} Boost::boost)
 
 if(MSVC AND NOT (MSVC_VERSION LESS 1915))

io/CMakeLists.txt

@@ -211,7 +211,7 @@ if(MINGW)
 endif()
 PCL_ADD_INCLUDES("${SUBSYS_NAME}" "${SUBSYS_NAME}/ply" ${PLY_INCLUDES})
 target_include_directories(pcl_io_ply PUBLIC "${CMAKE_CURRENT_SOURCE_DIR}/include")
-target_link_libraries(pcl_io_ply Boost::boost)
+target_link_libraries(pcl_io_ply pcl_common Boost::boost)
 
 set(srcs
   src/debayer.cpp
@@ -440,7 +440,3 @@ PCL_ADD_INCLUDES("${SUBSYS_NAME}" compression ${compression_incs})
 PCL_ADD_INCLUDES("${SUBSYS_NAME}" "${SUBSYS_NAME}/openni_camera" ${OPENNI_INCLUDES})
 PCL_ADD_INCLUDES("${SUBSYS_NAME}" "${SUBSYS_NAME}/openni2" ${OPENNI2_INCLUDES})
 PCL_ADD_INCLUDES("${SUBSYS_NAME}" "${SUBSYS_NAME}/impl" ${impl_incs})
-
-if(BUILD_tools)
-  add_subdirectory(tools)
-endif()