Skip to content

Commit 0b65607

Browse files
authored
Add missing standard library headers to groupby/hash and jit files (rapidsai#20982)
Add missing standard library headers to `cpp/src/groupby/hash/` and `cpp/src/jit/row_ir.*` files. Fixes builds for Velox. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Yunsong Wang (https://github.com/PointKernel) - Nghia Truong (https://github.com/ttnghia) - Muhammad Haseeb (https://github.com/mhaseeb123) URL: rapidsai#20982
1 parent ab0a22f commit 0b65607

8 files changed

Lines changed: 36 additions & 2 deletions

cpp/src/groupby/hash/compute_global_memory_aggs.cu

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
#include "compute_global_memory_aggs.cuh"
77

8+
#include <span>
9+
810
namespace cudf::groupby::detail::hash {
911

1012
template std::pair<std::unique_ptr<table>, rmm::device_uvector<size_type>>

cpp/src/groupby/hash/compute_global_memory_aggs.cuh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,11 @@
1818
#include <thrust/for_each.h>
1919
#include <thrust/tabulate.h>
2020

21+
#include <cstdint>
22+
#include <memory>
23+
#include <span>
24+
#include <utility>
25+
2126
namespace cudf::groupby::detail::hash {
2227

2328
namespace {

cpp/src/groupby/hash/compute_global_memory_aggs.hpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@
1212
#include <rmm/cuda_stream_view.hpp>
1313
#include <rmm/resource_ref.hpp>
1414

15+
#include <cstdint>
16+
#include <memory>
17+
#include <span>
18+
#include <utility>
19+
1520
namespace cudf::groupby::detail::hash {
1621
template <typename SetType>
1722
std::pair<std::unique_ptr<table>, rmm::device_uvector<size_type>> compute_global_memory_aggs(

cpp/src/groupby/hash/compute_global_memory_aggs_null.cu

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
#include "compute_global_memory_aggs.cuh"
77

8+
#include <span>
9+
810
namespace cudf::groupby::detail::hash {
911

1012
template std::pair<std::unique_ptr<table>, rmm::device_uvector<size_type>>

cpp/src/groupby/hash/output_utils.cu

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,14 @@
2323
#include <thrust/scatter.h>
2424
#include <thrust/transform.h>
2525

26+
#include <cstddef>
27+
#include <cstdint>
28+
#include <iterator>
29+
#include <memory>
30+
#include <span>
31+
#include <utility>
32+
#include <vector>
33+
2634
namespace cudf::groupby::detail::hash {
2735
namespace {
2836

cpp/src/groupby/hash/output_utils.hpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,11 @@
1515
#include <rmm/cuda_stream_view.hpp>
1616
#include <rmm/device_uvector.hpp>
1717

18+
#include <cstdint>
19+
#include <memory>
20+
#include <span>
21+
#include <vector>
22+
1823
namespace cudf::groupby::detail::hash {
1924

2025
/**

cpp/src/jit/row_ir.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION.
2+
* SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION.
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

@@ -12,7 +12,11 @@
1212
#include <algorithm>
1313
#include <format>
1414
#include <iostream>
15+
#include <iterator>
1516
#include <numeric>
17+
#include <span>
18+
#include <stdexcept>
19+
#include <utility>
1620

1721
namespace cudf {
1822

cpp/src/jit/row_ir.hpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION.
2+
* SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION.
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

@@ -14,12 +14,15 @@
1414
#include <rmm/resource_ref.hpp>
1515

1616
#include <array>
17+
#include <cstddef>
18+
#include <cstdint>
1719
#include <functional>
1820
#include <memory>
1921
#include <optional>
2022
#include <span>
2123
#include <string>
2224
#include <string_view>
25+
#include <tuple>
2326
#include <variant>
2427
#include <vector>
2528

0 commit comments

Comments
 (0)