Skip to content

Commit ad987ea

Browse files
authored
Add noinline to n_table_comparator::operator() (rapidsai#22699)
Adds the `noinline` declaration to the `n_table_comparator::operator()` function. This is based on the discussion and results here: rapidsai#22675 (comment) The attribute was necessary for the debug build but showed no issue in runtime for a release build. This PR makes the declaration non-conditional to make the code simpler to maintain. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Bradley Dice (https://github.com/bdice) - Muhammad Haseeb (https://github.com/mhaseeb123) - Yunsong Wang (https://github.com/PointKernel) URL: rapidsai#22699
1 parent 4742095 commit ad987ea

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

cpp/src/groupby/streaming_groupby/common.cuh

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,7 @@ struct n_table_comparator {
8686
key_location_t const* key_loc; ///< {batch_id, row_in_compacted} per dense ID
8787
size_type max_distinct_keys; ///< Threshold: idx >= max_distinct_keys is a transient batch value
8888

89-
#ifndef NDEBUG
90-
__attribute__((noinline))
91-
#endif
92-
__device__ bool
93-
operator()(size_type lhs, size_type rhs) const noexcept
89+
__attribute__((noinline)) __device__ bool operator()(size_type lhs, size_type rhs) const noexcept
9490
{
9591
bool const lhs_is_batch = (lhs >= max_distinct_keys);
9692
bool const rhs_is_batch = (rhs >= max_distinct_keys);

0 commit comments

Comments
 (0)