Skip to content

Commit 9ac70c7

Browse files
committed
docs: add comment
1 parent f7754cb commit 9ac70c7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scripts/deploy.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
# $GCP_SA, $FIREBASE_PROJECT_ID, $GCP_SA_STAGING, $FIREBASE_PROJECT_ID_STAGING are present in CircleCI
66
# $deploy_location is an environment variable set when the job is triggered by one of the two repositories getting pushed. If not present then the deploy was triggered by a commit on the master or staging branch of this very repository.
77

8-
export GOOGLE_APPLICATION_CREDENTIALS="$HOME"/gcp_sa.json
8+
export GOOGLE_APPLICATION_CREDENTIALS="$HOME"/gcp_sa.json # This SA needs Editor role. Firebase Admin isn't necessary. The
99

1010
if [ "${deploy_location:=$CIRCLE_BRANCH}" = 'master' ]; then
1111
echo 'Deploying master branches of PokeAPI/api-data and PokeAPI/pokeapi.co to https://pokeapi.co'

0 commit comments

Comments
 (0)