Skip to content

Commit 866d7d1

Browse files
DJ-Meyersclaude
andcommitted
fix: address LGPE encounter data PR feedback
- Rename rare-spawn to special-spawn encounter method - Remove 44 LGPE-specific location areas and remap encounters to existing RBY/FRLG areas - Duplicate encounters for multi-floor dungeons (Mt Moon, Pokemon Tower, Pokemon Mansion, Cerulean Cave) - Delete invalid Cerulean Cave b3f/b4f encounters (floors don't exist in LGPE) - Add tests job to GitHub Actions workflow Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 52f30b6 commit 866d7d1

5 files changed

Lines changed: 1291 additions & 1250 deletions

File tree

.github/workflows/database.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,21 @@ on:
44
pull_request:
55

66
jobs:
7+
tests:
8+
runs-on: ubuntu-latest
9+
steps:
10+
- name: Checkout
11+
uses: actions/checkout@v5
12+
with:
13+
submodules: recursive
14+
- name: Set up Python
15+
uses: actions/setup-python@v5
16+
with:
17+
python-version: '3.13'
18+
- name: Install dependencies
19+
run: make dev-install
20+
- name: Run tests
21+
run: make test
722
csv:
823
runs-on: ubuntu-latest
924
steps:

data/v2/csv/encounter_method_prose.csv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,4 +81,4 @@ encounter_method_id,local_language_id,name
8181
38,9,Walking in the overworld
8282
39,9,Surfing in the overworld
8383
40,9,Flying Pokemon in the sky
84-
41,9,Rare spawn after catch combo
84+
41,9,Special spawn after catch combo

data/v2/csv/encounter_methods.csv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,4 +39,4 @@ id,identifier,order
3939
38,overworld,38
4040
39,overworld-water,39
4141
40,overworld-flying,40
42-
41,rare-spawn,41
42+
41,special-spawn,41

0 commit comments

Comments
 (0)