Skip to content

Commit a2821c7

Browse files
authored
Merge pull request #1373 from PokeAPI/django4
Upgrade to django 4
2 parents 1449db8 + f204222 commit a2821c7

9 files changed

Lines changed: 30 additions & 32 deletions

File tree

config/settings.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838

3939
# If you set this to False, Django will not format dates, numbers and
4040
# calendars according to the current locale.
41-
USE_L10N = True
4241

4342
# If you set this to False, Django will not use timezone-aware datetimes.
4443
USE_TZ = True
@@ -62,7 +61,7 @@
6261

6362
DATABASES = {
6463
"default": {
65-
"ENGINE": "django.db.backends.postgresql_psycopg2",
64+
"ENGINE": "django.db.backends.postgresql",
6665
"NAME": "pokeapi_co_db",
6766
"USER": "root",
6867
"PASSWORD": "pokeapi",

config/urls.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
from django.conf.urls import include, url
1+
from django.urls import include, path
22
from pokemon_v2 import urls as pokemon_v2_urls
33

44
# pylint: disable=invalid-name
55

66
urlpatterns = [
7-
url(r"^", include(pokemon_v2_urls)),
7+
path("", include(pokemon_v2_urls)),
88
]

config/wsgi.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import os
1818
from django.core.wsgi import get_wsgi_application
1919

20-
2120
# We defer to a DJANGO_SETTINGS_MODULE already in the environment. This breaks
2221
# if running multiple sites in the same mod_wsgi process. To fix this, use
2322
# mod_wsgi daemon mode with each site in its own daemon process, or use

data/v2/build.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
from django.db import connection
2020
from pokemon_v2.models import *
2121

22-
2322
# why this way? how about use `__file__`
2423
DATA_LOCATION = "data/v2/csv/"
2524
DATA_LOCATION2 = os.path.join(os.path.dirname(__file__), "csv")

pokemon_v2/serializers.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
from .models import *
1212

13-
1413
#########################
1514
# SUMMARY SERIALIZERS #
1615
#########################

pokemon_v2/tests.py

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2693,7 +2693,7 @@ def test_item_api(self):
26932693
item_attribute_map.save()
26942694

26952695
response = self.client.get(
2696-
"{}/item/{}/".format(API_V2, item.pk), HTTP_HOST="testserver"
2696+
"{}/item/{}/".format(API_V2, item.pk), headers={"host": "testserver"}
26972697
)
26982698

26992699
# base params
@@ -4693,7 +4693,7 @@ def test_pokemon_species_api(self):
46934693

46944694
response = self.client.get(
46954695
"{}/pokemon-species/{}/".format(API_V2, pokemon_species.pk),
4696-
HTTP_HOST="testserver",
4696+
headers={"host": "testserver"},
46974697
)
46984698

46994699
self.assertEqual(response.status_code, status.HTTP_200_OK)
@@ -4957,7 +4957,7 @@ def test_pokemon_api(self):
49574957
max_level=36,
49584958
)
49594959
response = self.client.get(
4960-
"{}/pokemon/{}/".format(API_V2, pokemon.pk), HTTP_HOST="testserver"
4960+
"{}/pokemon/{}/".format(API_V2, pokemon.pk), headers={"host": "testserver"}
49614961
)
49624962

49634963
self.assertEqual(response.status_code, status.HTTP_200_OK)
@@ -5181,7 +5181,7 @@ def test_pokemon_api(self):
51815181

51825182
response = self.client.get(
51835183
"{}/pokemon/?q={}".format(API_V2, pokemon.name[:2]),
5184-
HTTP_HOST="testserver",
5184+
headers={"host": "testserver"},
51855185
)
51865186

51875187
self.assertEqual(response.status_code, status.HTTP_200_OK)
@@ -5207,7 +5207,7 @@ def test_pokemon_form_api(self):
52075207

52085208
response = self.client.get(
52095209
"{}/pokemon-form/{}/".format(API_V2, pokemon_form.pk),
5210-
HTTP_HOST="testserver",
5210+
headers={"host": "testserver"},
52115211
)
52125212

52135213
self.assertEqual(response.status_code, status.HTTP_200_OK)
@@ -5777,13 +5777,15 @@ def test_case_insensitive_api(self):
57775777

57785778
# Test lowercase
57795779
lowercase_response = self.client.get(
5780-
"{}/pokemon/{}/".format(API_V2, lowercase_name), HTTP_HOST="testserver"
5780+
"{}/pokemon/{}/".format(API_V2, lowercase_name),
5781+
headers={"host": "testserver"},
57815782
)
57825783
self.assertEqual(lowercase_response.status_code, status.HTTP_200_OK)
57835784

57845785
# Test uppercase
57855786
uppercase_response = self.client.get(
5786-
"{}/pokemon/{}/".format(API_V2, uppercase_name), HTTP_HOST="testserver"
5787+
"{}/pokemon/{}/".format(API_V2, uppercase_name),
5788+
headers={"host": "testserver"},
57875789
)
57885790
self.assertEqual(uppercase_response.status_code, status.HTTP_200_OK)
57895791

@@ -5797,12 +5799,14 @@ def test_case_insensitive_api(self):
57975799
uppercase_name = language.name.upper()
57985800

57995801
lowercase_response = self.client.get(
5800-
"{}/language/{}/".format(API_V2, lowercase_name), HTTP_HOST="testserver"
5802+
"{}/language/{}/".format(API_V2, lowercase_name),
5803+
headers={"host": "testserver"},
58015804
)
58025805
self.assertEqual(lowercase_response.status_code, status.HTTP_200_OK)
58035806

58045807
uppercase_response = self.client.get(
5805-
"{}/language/{}/".format(API_V2, uppercase_name), HTTP_HOST="testserver"
5808+
"{}/language/{}/".format(API_V2, uppercase_name),
5809+
headers={"host": "testserver"},
58065810
)
58075811
self.assertEqual(uppercase_response.status_code, status.HTTP_200_OK)
58085812

pokemon_v2/urls.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from django.conf.urls import include, url
1+
from django.urls import include, path, re_path
22

33
#####################################
44
#
@@ -70,8 +70,8 @@
7070
###########################
7171

7272
urlpatterns = [
73-
url(r"^api/v2/", include(router.urls)),
74-
url(
73+
path("api/v2/", include(router.urls)),
74+
re_path(
7575
r"^api/v2/pokemon/(?P<pokemon_id>\d+)/encounters",
7676
PokemonEncounterView.as_view(),
7777
name="pokemon_encounters",

requirements.txt

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
1-
Django==3.2.25
1+
Django==4.2.27
22
Unipath==1.1
3-
coverage==4.5.4
4-
django-cors-headers==3.14.0
5-
django-discover-runner==1.0
6-
django-redis==4.12.1
7-
django-cachalot==2.4.5
8-
djangorestframework==3.14.0
3+
coverage==7.13.1
4+
django-cors-headers==4.9.0
5+
django-redis==6.0.0
6+
django-cachalot==2.8.0
7+
djangorestframework==3.16.1
98
gunicorn==23.0.0
10-
mimeparse==0.1.3
11-
psycopg2-binary==2.9.10
12-
python-dateutil==2.8.2
13-
python-mimeparse==1.6.0
14-
drf-spectacular==0.28.0
9+
psycopg[binary]==3.3.2
10+
python-dateutil==2.9.0
11+
python-mimeparse==2.0.0
12+
drf-spectacular==0.29.0
1513
legacy-cgi; python_version >= '3.13'

test-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
-r requirements.txt
2-
black==23.12.1
2+
black==26.1.0

0 commit comments

Comments
 (0)