Skip to content

Add legacy-cgi for newer Python versions#1301

Merged
Naramsim merged 6 commits intoPokeAPI:masterfrom
jonbarrow:feat/legacy-cgi
Sep 16, 2025
Merged

Add legacy-cgi for newer Python versions#1301
Naramsim merged 6 commits intoPokeAPI:masterfrom
jonbarrow:feat/legacy-cgi

Conversation

@jonbarrow
Copy link
Copy Markdown
Contributor

As mentioned in #1300, this project is not currently usable by the latest versions of Python due to the Django version being a year and 2 major versions out of date. The version of Django currently used relies on the cgi module that was removed from Python in version 3.13

I still believe that updating to the latest version of Django is the better long term fix, but for now adding legacy-cgi as dependency at least gets things rolling with no code change

I will leave the mentioned issue open as I still believe it is relevant and this to not be a "proper" fix for the mentioned issue(s), this is just meant to be a temporary work-around

@Naramsim
Copy link
Copy Markdown
Member

Could you include python 13 in the cicd build system?

@Naramsim
Copy link
Copy Markdown
Member

Great! Thanks! Now we only need to update the readme https://github.com/PokeAPI/pokeapi/blob/master/README.md?plain=1#L36 and we can merge :) Thanks!

@jonbarrow
Copy link
Copy Markdown
Contributor Author

My bad, I actually completely missed that when looking through things the other day! I thought that wasn't posted anywhere

Copy link
Copy Markdown
Member

@phalt phalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor then I'd be happy to merge this.

Comment thread requirements.txt Outdated
@Naramsim Naramsim merged commit e09b056 into PokeAPI:master Sep 16, 2025
8 of 9 checks passed
@pokeapi-machine-user
Copy link
Copy Markdown

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@Naramsim
Copy link
Copy Markdown
Member

Thanks @jonbarrow !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants