Fix: Removed regional restrictions so Rattata can evolve into Raticate in any region

[joereg4]

The evolution data for Rattata → Raticate was incorrectly restricted to the Alola region only, preventing the evolution from occurring in other regions. This was identified by @Naramsim in the review of the evolution data.

Issue Details:

• Evolution entries had region_id=7 (Alola) and base_form_id=19 (Rattata)
• This incorrectly suggested that Rattata could only evolve into Raticate in Alola
• The evolution should be available in all regions, not just Alola

[phalt]

Poor Rattata!

[Naramsim]

Hi! Rattata is the only one I checked, could you human-verify some other additions we merged?

Also, where did you get the data from?

[joereg4]

A script that cycled through the bulbpedia API

[Naramsim]

Hi, Ninetales has the same problem:

https://staging.pokeapi.co/api/v2/pokemon-species/38 leads to https://staging.pokeapi.co/api/v2/evolution-chain/15/ that states that Ninetales needs to be in region alola to be evolved.

I think you need to revise your script and adjust the data.

[Naramsim]

Please check all the additions you added to this file in this PR #1299.

[Naramsim]

In the meantime I'll remove all the CSV data you've added so we can resume merging other PR and publishing to prod.

[joereg4]

@Naramsim I have taken a different approach. To make this work we need new evolution chains for the regional variants. Simply adding the region_id works for those that have two chains like this:

Meowth -> Persian, not locked to any Region (Chain 34)
Meowth -> Perrserker requires Galar (Chain 450)

And we won't need the base_form_id.

I'll resubmit with the region for these:

base_form_id,base_form_name,required_region,required_region_id,reason
83,farfetchd,galar,8,Farfetchd -> Sirfetchd requires Galar
562,yamask,galar,8,Yamask -> Runerigus requires Galar
52,meowth,galar,8,Meowth -> Perrserker requires Galar
123,scyther,hisui,9,Scyther -> Kleavor requires Hisui
203,girafarig,paldea,10,Girafarig -> Farigiraf requires Paldea

And then start working on evolution chains for Regional variants such as these since they conflict with the base form:

evolution_chain_id,name,region,region_id,base_form_id,base_form_name
7,rattata-alola,alola,7,19,rattata
11,sandshrew-alola,alola,7,27,sandshrew
15,vulpix-alola,alola,7,37,vulpix
21,diglett-alola,alola,7,50,diglett
22,meowth-alola,alola,7,52,meowth
31,geodude-alola,alola,7,74,geodude
38,grimer-alola,alola,7,88,grimer
22,meowth-galar,galar,8,52,meowth
32,ponyta-galar,galar,8,77,ponyta
33,slowpoke-galar,galar,8,79,slowpoke
35,farfetchd-galar,galar,8,83,farfetchd
73,articuno-galar,galar,8,144,articuno
74,zapdos-galar,galar,8,145,zapdos
75,moltres-galar,galar,8,146,moltres
113,corsola-galar,galar,8,222,corsola
134,zigzagoon-galar,galar,8,263,zigzagoon
282,darumaka-galar,galar,8,554,darumaka
287,yamask-galar,galar,8,562,yamask
313,stunfisk-galar,galar,8,618,stunfisk
25,growlithe-hisui,hisui,9,58,growlithe
44,voltorb-hisui,hisui,9,100,voltorb
106,qwilfish-hisui,hisui,9,211,qwilfish
109,sneasel-hisui,hisui,9,215,sneasel
291,zorua-hisui,hisui,9,570,zorua
96,wooper-paldea,paldea,10,194,wooper

This last part will take more time.