Add support for brilliant-diamond-shining-pearl and scarlet-violet sp…#1352
Merged
Naramsim merged 2 commits intoPokeAPI:masterfrom Dec 17, 2025
Merged
Add support for brilliant-diamond-shining-pearl and scarlet-violet sp…#1352Naramsim merged 2 commits intoPokeAPI:masterfrom
Naramsim merged 2 commits intoPokeAPI:masterfrom
Conversation
phalt
reviewed
Dec 15, 2025
Member
phalt
left a comment
phalt
left a comment
There was a problem hiding this comment.
Have you tested these generate the data correctly? I see no test changes :)
Member
|
I think everything is fine. First we need to add the sprites then merge this PR. |
Naramsim
reviewed
Dec 17, 2025
| poke_sprites + "back/shiny/female/", info, "png" | ||
| ), | ||
| "versions": { | ||
| "generation-viii": { |
Member
There was a problem hiding this comment.
I see what you are doing here. It's true that we don't expose the sprites (other than the ones in the root) for the pokemon forms.
Would it be feasible to detach the JSON logic for the pokemon serializer and then re-use it for both the serializers?
Naramsim
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I only extended the data model to match the new sprites introduced in this PR: PokeAPI/sprites#188
TODO: