-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update AI-assisted coding guidelines in CONTRIBUTING.md #1439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+35
−3
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e7ad0d7
Update AI-assisted coding guidelines in CONTRIBUTING.md
phalt 0650603
Update pull_request_template
phalt ee6e4d2
Merge branch 'master' into phalt-patch-1
Naramsim 16997b4
Update review template, modify contributing
phalt 6725cb0
Review feedback
phalt 64b1a49
Apply suggestion from @jemarq04
Naramsim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,15 +28,30 @@ Simple! | |
|
|
||
| ## AI assisted coding | ||
|
|
||
| Using AI assisted coding tools for auto complete, test generation, etc is allowed so long as a human is the overall primary author of a pull request. | ||
| The types of AI-assisted coding that will be accepted: | ||
|
|
||
| - Scaffolding for common framework patterns | ||
| - Scaffolding for test patternstest generation | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. test patterns/test generation |
||
| - Mass file editing for tedious repetitive changes | ||
|
|
||
| The types of AI changes that will **NOT** be accepted: | ||
|
|
||
| - Fully automated code generation | ||
| - AI generated comments and responses in code review | ||
|
phalt marked this conversation as resolved.
|
||
| - Lack of understanding of the change | ||
|
|
||
| Contributions from supervised AI assisted coding agents who build the majority (or all of) a change, such as [co pilot tasks](https://github.blog/changelog/2025-10-28-a-mission-control-to-assign-steer-and-track-copilot-coding-agent-tasks/), will be accepted only on the following basis: | ||
|
|
||
| 1. A human can verifiably prove they have reviewed and checked that the contribution does what it says it does. | ||
| 2. The human author provides evidence of the prompt given to the AI agent, and the logs of it producing the change. (For example - co pilot tasks produces a public log). | ||
| 3. The human author explicitly calls out that an supervised AI agent created the change when they make a pull request. | ||
| 2. If requested, the human author must provide evidence of the prompt given to the AI agent, and the logs of it producing the change. (For example - co pilot tasks produces a public log). | ||
| 3. If requested, the human author explicitly calls out that an supervised AI agent created the change when they make a pull request. | ||
| 4. The human author is prepared to own the change (just like any other change they make) and fix any issues that arise from it. | ||
|
phalt marked this conversation as resolved.
|
||
|
|
||
| ### Maintainers decision is final | ||
|
|
||
| If you cannot sufficiently demonstrate good use of AI tooling we will close your change. | ||
|
|
||
| We contribute to this project in our free time. Our time is valuable. Our time is not to be spent doing the thinking for you because you outsourced work to an LLM coding agent. | ||
|
|
||
| ## Financial contributions | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be an HTML comment? I think it's a good idea, but the opening tag should be
<!--and the closing one-->If we do like this the line is shown in the editor but no present in the rendered issue.