Open
Conversation
This pull request seeks to add all NPC trades from Pokemon Gold, Silver, and Crystal. To support the trades I had to: - Rename power plant to Kanto Power Plant (there's a Kalos Power Plant, so this seemed appropriate with the naming convention) - Add 2 new location areas for a house in violet city, and the goldenrrod department store. - Add encounters and encounter slots - Add encounter condition values and relevant prose for all new tradeable Pokemon, except abra, who is a repeat condition from RBY.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request seeks to add all NPC trades from Pokemon Gold, Silver, and Crystal.
To support the trades I had to:
Rename power plant location to Kanto Power Plant (there's a Kalos Power Plant, so this seemed appropriate with the naming convention)
Add 2 new location areas for a house in violet city, and the goldenrod department store.
Add encounters and encounter slots
Add encounter condition values and relevant prose for all new tradeable Pokemon, except abra, who is a repeat condition from RBY.
I also removed the ! from the NPC trade condition prose.