Support py34 and py35 (#39)

- Update circle/ci config
- workaround for python 3.4
- Document python 3.4 and 3.5 support

Author: Kronopt

.circleci/config.yml

@@ -15,6 +15,30 @@ jobs:
           name: Run Tests
           command: python -m unittest discover tests
 
+  py34:
+    docker:
+      - image: circleci/python:3.4.10
+    steps:
+      - checkout
+      - run:
+          name: Install Requirements
+          command: pip install -r requirements.txt -r requirements-dev27.txt --user
+      - run:
+          name: Run Tests
+          command: python -m unittest
+
+  py35:
+    docker:
+      - image: circleci/python:3.5.7
+    steps:
+      - checkout
+      - run:
+          name: Install Requirements
+          command: pip install -r requirements.txt -r requirements-dev27.txt --user
+      - run:
+          name: Run Tests
+          command: python -m unittest
+
   py36:
     docker:
       - image: circleci/python:3.6.8
@@ -56,5 +80,7 @@ workflows:
   run_tests:
     jobs:
       - py27
+      - py34
+      - py35
       - py36
       - py37

docs/contributing.md

@@ -100,7 +100,7 @@ Before submiting a pull request, check that it meets these guidelines:
    Put your new functionality into a function with a docstring, and add the
    feature to the list in [README](https://github.com/PokeAPI/pokepy/blob/master/README.md).
 
-**3 .** The pull request should work for Python 2.7, 3.6, and 3.7.
+**3 .** The pull request should work for Python 2.7, 3.4, 3.5, 3.6, and 3.7.
 
 ### Tips
 To run a subset of tests:

pokepy/api.py

@@ -215,9 +215,10 @@ def memoize(func):
 
             if disk_or_memory == 'disk':
                 if cache_directory:
-                    # Python 2 workaround
-                    if sys.version_info[0] == 2 and not isinstance(cache_directory, str):
-                        raise TypeError('expected str')
+                    # Python 2 and 3.4 workaround
+                    if (sys.version_info[0] == 2 or sys.version_info[0:2] == (3, 4)) and \
+                            not isinstance(cache_directory, str):
+                        raise TypeError('expected str, not %s' % cache_directory.__class__.__name__)
 
                     _global_cache_dir = os.path.join(cache_directory, 'pokepy_cache')
                     cache_dir = os.path.join(_global_cache_dir, str(get_methods_id[0]))

setup.py

@@ -41,6 +41,8 @@
         'Programming Language :: Python :: 2',
         'Programming Language :: Python :: 2.7',
         'Programming Language :: Python :: 3',
+        'Programming Language :: Python :: 3.4',
+        'Programming Language :: Python :: 3.5',
         'Programming Language :: Python :: 3.6',
         'Programming Language :: Python :: 3.7',
     ],

tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = py27,py36,py37
+envlist = py27,py34,py35,py36,py37
 
 [testenv]
 setenv =