Skip to content

Commit 9a136fc

Browse files
author
Paul Hallett
committed
Description attribute added to Pokemon class
1 parent d7fe788 commit 9a136fc

5 files changed

Lines changed: 17 additions & 9 deletions

File tree

HISTORY.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@
33
History
44
-------
55

6+
0.1.1 (2013-12-24)
7+
++++++++++++++++++
8+
9+
* Description attribute added to Pokemon class
10+
11+
612
0.1.0 (2013-12-23)
713
++++++++++++++++++
814

pykemon/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
__author__ = 'Paul Hallett'
55
__email__ = 'hello@phalt.co'
6-
__version__ = '0.1.0'
6+
__version__ = '0.1.1'
77
__copyright__ = 'Copyright Paul Hallett 2013'
88
__license__ = 'BSD'
99

pykemon/models.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ def __init__(self, bundle):
3333
self.egg_groups = buildr(bundle, 'egg_groups')
3434
self.evolutions = {
3535
f['to']: f['resource_uri'] for f in bundle['evolutions']}
36+
self.descriptions = buildr(bundle, 'descriptions')
3637
self.moves = buildr(bundle, 'moves')
3738
self.types = buildr(bundle, 'types')
3839
self.catch_rate = bundle['catch_rate']

setup.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919

2020
setup(
2121
name='pykemon',
22-
version='0.1.0',
23-
description='A python wrapper for PokeAPI',
22+
version='0.1.1',
23+
description='A Python wrapper for PokeAPI',
2424
long_description=readme + '\n\n' + history,
2525
author='Paul Hallett',
2626
author_email='hello@phalt.co',
@@ -37,7 +37,7 @@
3737
zip_safe=False,
3838
keywords='pykemon',
3939
classifiers=[
40-
'Development Status :: 3 - Beta',
40+
'Development Status :: 4 - Beta',
4141
'Intended Audience :: Developers',
4242
'License :: OSI Approved :: BSD License',
4343
'Natural Language :: English',

tests/test_pykemon.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def setUp(self):
2222
self.type_one = pykemon.get(type_id=10) # Fire
2323
self.ability_one = pykemon.get(ability_id=1) # Stench
2424
self.egg_one = pykemon.get(egg_id=1) # Monster
25-
self.description_one = pykemon.get(description_id=1)
25+
self.description_one = pykemon.get(description_id=2)
2626
self.sprite_one = pykemon.get(sprite_id=152) # Mew_auto
2727
self.game_one = pykemon.get(game_id=4) # Red
2828

@@ -32,7 +32,7 @@ def test_name_attribute(self):
3232
self.assertEquals(self.type_one.name, 'Fire')
3333
self.assertEquals(self.ability_one.name, 'Stench')
3434
self.assertEquals(self.egg_one.name, 'Monster')
35-
self.assertEquals(self.description_one.name, 'Bulbasaur_red_blue')
35+
self.assertEquals(self.description_one.name, 'Bulbasaur_gen_1')
3636
self.assertEquals(self.sprite_one.name, 'Mew_auto')
3737
self.assertEquals(self.game_one.name, 'Red')
3838

@@ -43,7 +43,7 @@ def test_repr(self):
4343
self.assertEquals(str(self.ability_one), '<Ability - Stench>')
4444
self.assertEquals(str(self.egg_one), '<Egg - Monster>')
4545
self.assertEquals(
46-
str(self.description_one), '<Description - Bulbasaur_red_blue>')
46+
str(self.description_one), '<Description - Bulbasaur_gen_1>')
4747
self.assertEquals(str(self.sprite_one), '<Sprite - Mew_auto>')
4848
self.assertEquals(str(self.game_one), '<Game - Red>')
4949

@@ -54,7 +54,7 @@ def test_resource_uri_attribute(self):
5454
self.assertEquals(self.ability_one.resource_uri, '/api/v1/ability/1/')
5555
self.assertEquals(self.egg_one.resource_uri, '/api/v1/egg/1/')
5656
self.assertEquals(
57-
self.description_one.resource_uri, '/api/v1/description/1/')
57+
self.description_one.resource_uri, '/api/v1/description/2/')
5858
self.assertEquals(self.sprite_one.resource_uri, '/api/v1/sprite/152/')
5959
self.assertEquals(self.game_one.resource_uri, '/api/v1/game/4/')
6060

@@ -64,6 +64,7 @@ def test_pokemon_complex_attribs(self):
6464
self.assertIn('grass', self.poke_one.types)
6565
self.assertIn('overgrow', self.poke_one.abilities)
6666
self.assertIn('Monster', self.poke_one.egg_groups)
67+
self.assertIn('bulbasaur_gen_1', self.poke_one.descriptions)
6768

6869
def test_type_complex_attribs(self):
6970
self.assertIn('grass', self.type_one.super_effective)
@@ -75,7 +76,7 @@ def test_egg_complex_attribs(self):
7576
self.assertIn('Blastoise', self.egg_one.pokemon)
7677

7778
def test_description_complex_attribs(self):
78-
self.assertIn('blue', self.description_one.games)
79+
self.assertIn('red(JPN)', self.description_one.games)
7980

8081

8182
class Testexceptions(unittest.TestCase):

0 commit comments

Comments
 (0)