fix: do not recreate group if redis is empty (#114)

* fix: do not recreate group if redis is empty

* fix: fixed the fix

* fix: add ttl

* perf: fill redis once to avoid too many backend calls

* fix: remove ttl, otherwise we lose track

this Redis collection will be manually deleted

* fix: void the fillRedis promise

---------

Co-authored-by: Lorenzo Corallo <lorenzo.corallo@outlook.it>
Co-authored-by: Lorenzo Corallo <66379281+lorenzocorallo@users.noreply.github.com>

Author: toto04

src/middlewares/bot-membership-handler.ts

@@ -47,15 +47,14 @@ export class BotMembershipHandler<C extends TelemetryContextFlavor<Context>> ext
   constructor() {
     super("bot_membership_handler")
 
+    void this.fillRedis()
+
     // TEMP: this is for initial migration from previous bot
     this.composer.fork().filter(predicate, async (ctx, next) => {
       if (ctx.chat.type === "private") return next()
 
       const redisCheck = await this.TEMP_redis.has(ctx.chat.id.toString())
-      if (redisCheck) {
-        const backendGroup = await api.tg.groups.getById.query({ telegramId: ctx.chat.id }).catch(() => null)
-        if (backendGroup !== null) return next()
-      }
+      if (redisCheck) return next()
 
       const me = await ctx.getChatMember(ctx.me.id).catch(() => ({ status: "undefined" }))
       if (me.status !== "administrator") {
@@ -93,6 +92,11 @@ export class BotMembershipHandler<C extends TelemetryContextFlavor<Context>> ext
     })
   }
 
+  private async fillRedis() {
+    const dbGroups = await api.tg.groups.getAll.query()
+    await Promise.all(dbGroups.map((g) => this.TEMP_redis.write(g.telegramId.toString(), g.telegramId)))
+  }
+
   private static isJoin<C extends Context>(ctx: MemberContext<C>): boolean {
     const oldStatusCheck = ["left", "kicked"].includes(ctx.myChatMember.old_chat_member.status)
     const newStatusCheck = joinEvent[ctx.myChatMember.chat.type].includes(ctx.myChatMember.new_chat_member.status)