Skip to content

Commit f72f01f

Browse files
committed
Fix deploy workflow shell quoting
1 parent cb89e7c commit f72f01f

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

.github/workflows/deploy.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,14 @@ jobs:
131131
uses: google-github-actions/setup-gcloud@v3
132132

133133
- name: Configure Docker for Artifact Registry
134-
run: gcloud auth configure-docker ${{ vars.GCP_REGION }}-docker.pkg.dev
134+
run: gcloud auth configure-docker "${{ vars.GCP_REGION }}-docker.pkg.dev"
135135

136136
- name: Build and push Docker image
137137
run: |
138-
docker build -t $IMAGE_URL:${{ github.sha }} .
139-
docker tag $IMAGE_URL:${{ github.sha }} $IMAGE_URL:latest
140-
docker push $IMAGE_URL:${{ github.sha }}
141-
docker push $IMAGE_URL:latest
138+
docker build -t "${IMAGE_URL}:${{ github.sha }}" .
139+
docker tag "${IMAGE_URL}:${{ github.sha }}" "${IMAGE_URL}:latest"
140+
docker push "${IMAGE_URL}:${{ github.sha }}"
141+
docker push "${IMAGE_URL}:latest"
142142
143143
infra:
144144
name: Apply infrastructure
@@ -305,7 +305,7 @@ jobs:
305305
run: |
306306
gcloud run deploy ${{ vars.API_SERVICE_NAME }} \
307307
--region=${{ vars.GCP_REGION }} \
308-
--image=$IMAGE_URL:${{ github.sha }} \
308+
--image="${IMAGE_URL}:${{ github.sha }}" \
309309
--tag=staging \
310310
--no-traffic \
311311
--update-env-vars=MODAL_ENVIRONMENT=staging,LOGFIRE_ENVIRONMENT=staging,SUPABASE_URL=${{ secrets.SUPABASE_URL }},SUPABASE_KEY=${{ secrets.SUPABASE_KEY }},SUPABASE_SECRET_KEY=${{ secrets.SUPABASE_SECRET_KEY }},SUPABASE_DB_URL=${{ secrets.SUPABASE_DB_URL }}
@@ -472,7 +472,7 @@ jobs:
472472
run: |
473473
gcloud run deploy ${{ vars.API_SERVICE_NAME }} \
474474
--region=${{ vars.GCP_REGION }} \
475-
--image=$IMAGE_URL:${{ github.sha }} \
475+
--image="${IMAGE_URL}:${{ github.sha }}" \
476476
--tag=canary \
477477
--no-traffic \
478478
--update-env-vars=MODAL_ENVIRONMENT=main,LOGFIRE_ENVIRONMENT=prod

0 commit comments

Comments
 (0)