Skip to content

Commit 22c7c4b

Browse files
anth-volkclaude
andcommitted
Fix stale us_model_version in integration tests
Update hardcoded 1.459.0 defaults to 1.562.3 in conftest.py and app.py. Wire deployed US version from deploy job through CI to the integration test script so it always targets the actually-deployed version. Fixes #413 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent f95b784 commit 22c7c4b

4 files changed

Lines changed: 10 additions & 4 deletions

File tree

.github/scripts/modal-run-integ-tests.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,23 @@
11
#!/bin/bash
22
# Run simulation integration tests
3-
# Usage: ./modal-run-integ-tests.sh <environment> <base-url>
3+
# Usage: ./modal-run-integ-tests.sh <environment> <base-url> [us-version]
44
# Environment: beta runs all tests, prod excludes beta_only tests
55

66
set -euo pipefail
77

88
ENVIRONMENT="${1:?Environment required (beta or prod)}"
99
BASE_URL="${2:?Base URL required}"
10+
US_VERSION="${3:-}"
1011

1112
cd projects/policyengine-apis-integ
1213
uv sync --extra test
1314

1415
export simulation_integ_test_base_url="$BASE_URL"
1516

17+
if [ -n "$US_VERSION" ]; then
18+
export simulation_integ_test_us_model_version="$US_VERSION"
19+
fi
20+
1621
if [ "$ENVIRONMENT" = "beta" ]; then
1722
echo "Running all simulation integration tests (including beta_only)"
1823
uv run pytest tests/simulation/ -v

.github/workflows/modal-deploy.reusable.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ jobs:
2323
environment: ${{ inputs.environment }}
2424
outputs:
2525
simulation_api_url: ${{ steps.get-url.outputs.simulation_api_url }}
26+
us_version: ${{ steps.versions.outputs.us_version }}
2627

2728
steps:
2829
- name: Checkout repo
@@ -101,4 +102,4 @@ jobs:
101102
run: ./scripts/generate-clients.sh
102103

103104
- name: Run simulation integration tests
104-
run: .github/scripts/modal-run-integ-tests.sh "${{ inputs.environment }}" "${{ needs.deploy.outputs.simulation_api_url }}"
105+
run: .github/scripts/modal-run-integ-tests.sh "${{ inputs.environment }}" "${{ needs.deploy.outputs.simulation_api_url }}" "${{ needs.deploy.outputs.us_version }}"

projects/policyengine-api-simulation/src/modal/app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
from src.modal._image_setup import snapshot_models
1414

1515
# Get versions from environment or use defaults
16-
US_VERSION = os.environ.get("POLICYENGINE_US_VERSION", "1.459.0")
16+
US_VERSION = os.environ.get("POLICYENGINE_US_VERSION", "1.562.3")
1717
UK_VERSION = os.environ.get("POLICYENGINE_UK_VERSION", "2.65.9")
1818

1919

projects/policyengine-apis-integ/tests/simulation/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class Settings(BaseSettings):
1010
access_token: str | None = None
1111
timeout_in_millis: int = 600_000 # 10 minutes for full simulations
1212
poll_interval_seconds: float = 5.0
13-
us_model_version: str = "1.459.0"
13+
us_model_version: str = "1.562.3"
1414

1515
model_config = SettingsConfigDict(env_prefix="simulation_integ_test_")
1616

0 commit comments

Comments
 (0)