Add test for Utah state tax reform (#2418)

* Add test for Utah state tax reform
Fixes #2417

* Move test

* Fix data input

* Fix test

* chore: Add docs

* Ensure the job saves correctly

* Adjust test after running locally to check

* Add test for loser share

---------

Co-authored-by: Anthony Volk <anth.volk@gmail.com>

Author: nikhilwoodruff

changelog_entry.yaml

@@ -0,0 +1,4 @@
+- bump: patch
+  changes:
+    added:
+    - Utah state tax reform test.

policyengine_api/jobs/calculate_economy_simulation_job.py

@@ -151,12 +151,23 @@ def run(
 
             # Kick off APIv2 job
             if use_api_v2:
+                data = None
+                v2_region = region
+                if data == "enhanced_cps":
+                    data = "gs://policyengine-us-data/enhanced_cps_2024.h5"
+                elif country_id == "us" and region != "us":
+                    data = (
+                        "gs://policyengine-us-data/pooled_3_year_cps_2023.h5"
+                    )
+                    v2_region = "state/" + region
                 input_data = {
                     "country": country_id,
                     "scope": "macro",
                     "reform": json.loads(reform_policy),
                     "baseline": json.loads(baseline_policy),
                     "time_period": time_period,
+                    "region": v2_region,
+                    "data": data,
                 }
                 execution = self.api_v2.run(input_data)
 

tests/data/utah_reform.json

@@ -0,0 +1,28 @@
+{
+  "data": {
+    "gov.states.ut.tax.income.rate": {
+      "2025-01-01.2100-12-31": 0.0455
+    },
+    "gov.states.ut.tax.income.credits.ctc.child_age_threshold[0].amount": {
+      "2025-01-01.2100-12-31": false
+    },
+    "gov.states.ut.tax.income.credits.ctc.child_age_threshold[2].threshold": {
+      "2025-01-01.2100-12-31": 5
+    },
+    "gov.states.ut.tax.income.credits.ss_benefits.phase_out.threshold.JOINT": {
+      "2025-01-01.2100-12-31": 75000
+    },
+    "gov.states.ut.tax.income.credits.ss_benefits.phase_out.threshold.SINGLE": {
+      "2025-01-01.2100-12-31": 45000
+    },
+    "gov.states.ut.tax.income.credits.ss_benefits.phase_out.threshold.SEPARATE": {
+      "2025-01-01.2100-12-31": 37500
+    },
+    "gov.states.ut.tax.income.credits.ss_benefits.phase_out.threshold.SURVIVING_SPOUSE": {
+      "2025-01-01.2100-12-31": 75000
+    },
+    "gov.states.ut.tax.income.credits.ss_benefits.phase_out.threshold.HEAD_OF_HOUSEHOLD": {
+      "2025-01-01.2100-12-31": 75000
+    }
+  }
+}

tests/to_refactor/python/test_us_policy_macro.py

@@ -0,0 +1,89 @@
+import json
+import time
+import datetime
+from policyengine_api.data import local_database
+import sys
+
+# This test is a temporary test to ensure state impacts work properly.
+# It should be replaced with more comprehensive integration tests, then removed.
+
+
+def test_utah(rest_client):
+    """
+    Test that the a given Utah policy is calculated
+    and provides logical outputs for a sim
+    """
+
+    return utah_reform_runner(rest_client, "ut")
+
+
+def utah_reform_runner(rest_client, region: str = "us"):
+    """
+    Run the given Utah policy test, depending on provided
+    region (defaults to "us")
+    """
+
+    test_year = 2025
+    default_policy = 2
+
+    with open(
+        "./tests/data/utah_reform.json",
+        "r",
+        encoding="utf-8",
+    ) as f:
+        data_object = json.load(f)
+
+    local_database.query("DELETE FROM reform_impact WHERE country_id = 'us'")
+
+    policy_create = rest_client.post(
+        "/us/policy",
+        headers={"Content-Type": "application/json"},
+        json=data_object,
+    )
+
+    assert policy_create.status_code in [200, 201]
+    assert policy_create.json["result"] is not None
+
+    policy_id = policy_create.json["result"]["policy_id"]
+    assert policy_id is not None
+
+    query = f"/us/economy/{policy_id}/over/{default_policy}?region={region}&time_period={test_year}"
+    economy_response = rest_client.get(query)
+    assert economy_response.status_code == 200
+    assert economy_response.json["status"] == "computing", (
+        f'Expected first answer status to be "computing" but it is '
+        f'{str(economy_response.json["status"])}'
+    )
+    while economy_response.json["status"] == "computing":
+        print("Before sleep:", datetime.datetime.now())
+        time.sleep(3)
+        print("After sleep:", datetime.datetime.now())
+        economy_response = rest_client.get(query)
+        print(json.dumps(economy_response.json))
+    assert (
+        economy_response.json["status"] == "ok"
+    ), f'Expected status "ok", got {economy_response.json["status"]} with message "{economy_response.json}"'
+
+    result = economy_response.json["result"]
+
+    assert result is not None
+
+    # Ensure that there is some budgetary impact
+    cost = round(result["budget"]["budgetary_impact"] / 1e6, 1)
+    assert (
+        cost / 95.4 - 1
+    ) < 0.01, (
+        f"Expected budgetary impact to be 95.4 million, got {cost} million"
+    )
+
+    assert (
+        result["intra_decile"]["all"]["Lose less than 5%"] / 0.622 - 1
+    ) < 0.01, (
+        f"Expected 62.2% of people to lose less than 5%, got "
+        f"{result['intra_decile']['all']['Lose less than 5%']}"
+    )
+
+    local_database.query(
+        f"DELETE FROM policy WHERE id = ? ",
+        (policy_id,),
+    )