V2-V1 comparison checks use non-existent V2 result property (#2536)

nikhilwoodruff · web-flow · commit 1d321ea989a2 · 2025-06-04T00:18:45.000+01:00
* Fix issue

* Format
diff --git a/changelog_entry.yaml b/changelog_entry.yaml
@@ -0,0 +1,4 @@
+- bump: patch
+  changes:
+    fixed:
+    - V2 comparisons.
diff --git a/policyengine_api/jobs/calculate_economy_simulation_job.py b/policyengine_api/jobs/calculate_economy_simulation_job.py
@@ -215,11 +215,12 @@ def run(
                         progress_log.model_dump(mode="json"), severity="INFO"
                     )
                 except Exception as e:
+                    trace = traceback.format_exc()
                     # Send error log to GCP
                     error_log: V2V1Comparison = V2V1Comparison.model_validate(
                         {
                             **comparison_data,
-                            "v2_error": str(e),
+                            "v2_error": trace,
                         }
                     )
                     logger.log_struct(
@@ -265,9 +266,7 @@ def run(
                         api_v2_execution
                     )
 
-                    v2_country_package_version = api_v2_output[
-                        "country_package_version"
-                    ]
+                    v2_country_package_version = api_v2_output["model_version"]
 
                     completion_log: V2V1Comparison = (
                         V2V1Comparison.model_validate(
@@ -310,11 +309,12 @@ def run(
                     )
 
                 except Exception as e:
+                    trace = traceback.format_exc()
                     # If job fails, send error log to GCP
                     error_log: V2V1Comparison = V2V1Comparison.model_validate(
                         {
                             **comparison_data,
-                            "v2_error": str(e),
+                            "v2_error": trace,
                             "v1_impact": impact,
                             "v2_impact": None,
                             "v1_v2_diff": None,

Original file line number	Diff line number	Diff line change
`@@ -215,11 +215,12 @@ def run(`
`215`	`215`	`progress_log.model_dump(mode="json"), severity="INFO"`
`216`	`216`	`)`
`217`	`217`	`except Exception as e:`
	`218`	`+ trace = traceback.format_exc()`
`218`	`219`	`# Send error log to GCP`
`219`	`220`	`error_log: V2V1Comparison = V2V1Comparison.model_validate(`
`220`	`221`	`{`
`221`	`222`	`**comparison_data,`
`222`		`- "v2_error": str(e),`
	`223`	`+ "v2_error": trace,`
`223`	`224`	`}`
`224`	`225`	`)`
`225`	`226`	`logger.log_struct(`
`@@ -265,9 +266,7 @@ def run(`
`265`	`266`	`api_v2_execution`
`266`	`267`	`)`
`267`	`268`
`268`		`- v2_country_package_version = api_v2_output[`
`269`		`- "country_package_version"`
`270`		`- ]`
	`269`	`+ v2_country_package_version = api_v2_output["model_version"]`
`271`	`270`
`272`	`271`	`completion_log: V2V1Comparison = (`
`273`	`272`	`V2V1Comparison.model_validate(`
`@@ -310,11 +309,12 @@ def run(`
`310`	`309`	`)`
`311`	`310`
`312`	`311`	`except Exception as e:`
	`312`	`+ trace = traceback.format_exc()`
`313`	`313`	`# If job fails, send error log to GCP`
`314`	`314`	`error_log: V2V1Comparison = V2V1Comparison.model_validate(`
`315`	`315`	`{`
`316`	`316`	`**comparison_data,`
`317`		`- "v2_error": str(e),`
	`317`	`+ "v2_error": trace,`
`318`	`318`	`"v1_impact": impact,`
`319`	`319`	`"v2_impact": None,`
`320`	`320`	`"v1_v2_diff": None,`