Rename simulation gateway health probe

Author: anth-volk

docs/migration-pr3-cloud-run-candidate-runbook.md

@@ -158,14 +158,14 @@ After GitHub Actions prints the candidate URL:
 curl -i "$CLOUD_RUN_CANDIDATE_URL/health"
 curl -i "$CLOUD_RUN_CANDIDATE_URL/readiness-check"
 curl -i "$CLOUD_RUN_CANDIDATE_URL/liveness-check"
-curl -i "$CLOUD_RUN_CANDIDATE_URL/health/simulation-gateway"
+curl -i "$CLOUD_RUN_CANDIDATE_URL/simulation-gateway-check"
 curl -i "$CLOUD_RUN_CANDIDATE_URL/us/metadata"
 ```
 
 Expected behavior:
 
 - `/health` returns FastAPI JSON: `{"status":"healthy"}`.
-- `/health/simulation-gateway` returns FastAPI JSON confirming the existing
+- `/simulation-gateway-check` returns FastAPI JSON confirming the existing
   simulation gateway client can initialize and reach the gateway health check.
 - `/readiness-check` and `/liveness-check` return existing Flask text `OK`.
 - `/us/metadata` returns the existing v1 metadata contract from Cloud SQL.

policyengine_api/asgi_factory.py

@@ -17,7 +17,7 @@
 FASTAPI_NATIVE_LOGGED_PATHS = frozenset(
     {
         "/health",
-        "/health/simulation-gateway",
+        "/simulation-gateway-check",
     }
 )
 
@@ -78,7 +78,7 @@ def health() -> HealthResponse:
         return HealthResponse(status="healthy")
 
     @app.get(
-        "/health/simulation-gateway",
+        "/simulation-gateway-check",
         response_model=SimulationGatewayHealthResponse,
         include_in_schema=False,
     )

policyengine_api/migration_flags.py

@@ -71,7 +71,7 @@ def infer_route_group(path: str) -> str:
         return "home"
     if path in {
         "/health",
-        "/health/simulation-gateway",
+        "/simulation-gateway-check",
         "/liveness-check",
         "/readiness-check",
     }:

tests/integration/test_cloud_run_candidate.py

@@ -11,7 +11,7 @@ def test_cloud_run_candidate_health_routes(api_client):
     assert readiness_response.status_code == 200, readiness_response.text
     assert readiness_response.text == "OK"
 
-    simulation_gateway_response = api_client.get("/health/simulation-gateway")
+    simulation_gateway_response = api_client.get("/simulation-gateway-check")
     assert simulation_gateway_response.status_code == 200, (
         simulation_gateway_response.text
     )

tests/unit/test_asgi_factory.py

@@ -170,7 +170,7 @@ def test_public_simulation_gateway_health_probe_checks_gateway():
     ) as simulation_api:
         simulation_api.return_value.health_check.return_value = True
 
-        response = client.get("/health/simulation-gateway")
+        response = client.get("/simulation-gateway-check")
 
     assert response.status_code == 200
     assert response.json() == {
@@ -189,7 +189,7 @@ def test_public_simulation_gateway_health_probe_reports_failure():
     ) as simulation_api:
         simulation_api.return_value.health_check.return_value = False
 
-        response = client.get("/health/simulation-gateway")
+        response = client.get("/simulation-gateway-check")
 
     assert response.status_code == 503
 

tests/unit/test_migration_flags.py

@@ -58,7 +58,7 @@ def test_invalid_migration_flag_raises(monkeypatch):
     [
         ("/", "home"),
         ("/health", "health"),
-        ("/health/simulation-gateway", "health"),
+        ("/simulation-gateway-check", "health"),
         ("/readiness-check", "health"),
         ("/us/metadata", "metadata"),
         ("/us/policy/1", "policy"),