Skip to content

Created test_create_profile.py#2505

Merged
anth-volk merged 2 commits into
masterfrom
test-create-profile
Jul 24, 2025
Merged

Created test_create_profile.py#2505
anth-volk merged 2 commits into
masterfrom
test-create-profile

Conversation

@SongmingFan123

@SongmingFan123 SongmingFan123 commented May 26, 2025

Copy link
Copy Markdown
Collaborator

Fixes #2590

@codecov

codecov Bot commented May 26, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.79%. Comparing base (49eb8ba) to head (e59021b).
Report is 114 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2505      +/-   ##
==========================================
+ Coverage   63.62%   63.79%   +0.16%     
==========================================
  Files          56       56              
  Lines        2161     2215      +54     
  Branches      287      296       +9     
==========================================
+ Hits         1375     1413      +38     
- Misses        729      741      +12     
- Partials       57       61       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anth-volk

Copy link
Copy Markdown
Collaborator

Please add a changelog, run the linter, and add Fixes #ISSUE to the description.

@anth-volk anth-volk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @SongmingFan123! LGTM once you address the comments above.

@anth-volk

Copy link
Copy Markdown
Collaborator

Again, please add "Fixes #NUMBER" in the PR description

@SongmingFan123

Copy link
Copy Markdown
Collaborator Author

Again, please add "Fixes #NUMBER" in the PR description

Fixed, thank you for the feedback

@anth-volk

Copy link
Copy Markdown
Collaborator

#2348 is a PR, not an issue. Please create an issue and link that here.

@SongmingFan123

Copy link
Copy Markdown
Collaborator Author

#2348 is a PR, not an issue. Please create an issue and link that here.

Updated.

@anth-volk anth-volk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this through! LGTM!

@anth-volk anth-volk merged commit 0e62627 into master Jul 24, 2025
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create test create profile

3 participants