Created an example environment variable file#2521
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2521 +/- ##
==========================================
+ Coverage 63.62% 63.64% +0.02%
==========================================
Files 56 56
Lines 2161 2220 +59
Branches 287 296 +9
==========================================
+ Hits 1375 1413 +38
- Misses 729 744 +15
- Partials 57 63 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -1,5 +1,6 @@ | |||
| install: | |||
| pip install -e ".[dev]" --config-settings editable_mode=compat | |||
| if [ ! -f .env ]; then cp .env.example .env; fi | |||
There was a problem hiding this comment.
nit, probably not blocking: Bash scripts in Makefiles & GH Actions are a personal peeve of mine; could we place this in a separate .sh file in the GitHub directory then run the script?
| # API Key for OpenAI | ||
| OPENAI_API_KEY=policyengine_openai_api_key |
There was a problem hiding this comment.
question: Could you confirm if this is still used? I thought we had removed the code that needed this key.
There was a problem hiding this comment.
I checked the codebase, and OPENAI_API_KEY is still actively used in several files, including gpt4_api_user.py, export.py, Dockerfile, __init__.py, client.py, azure.py, METADATA, pr.yml, and push.yml.
For example, in gpt4_api_user.py it’s used like this:
# Point OpenAI to the API key
openai.api_key = os.environ["OPENAI_API_KEY"]There was a problem hiding this comment.
I see. It does appear that it isn't used for the most part in prod, only in some old code that isn't run, but I can see value in including.
| # API Key for OpenAI | ||
| OPENAI_API_KEY=policyengine_openai_api_key |
There was a problem hiding this comment.
I see. It does appear that it isn't used for the most part in prod, only in some old code that isn't run, but I can see value in including.
3 participants
Fixes #2443