Ensure that when API v1 attempts deploy, API v2 runs with required model version#2547
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2547 +/- ##
=======================================
Coverage 63.55% 63.55%
=======================================
Files 56 56
Lines 2220 2220
Branches 296 296
=======================================
Hits 1411 1411
Misses 747 747
Partials 62 62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Looks reasonable but can we get a PR test passing with this first |
bc6c34d to
fdf81e2
Compare
jq install
Collaborator
Author
|
An example of this script setup passing on PR available here. |
Merged
mikesmit
approved these changes
Jun 9, 2025
mikesmit
left a comment
Collaborator
There was a problem hiding this comment.
Let's get this moving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2564
Redo of #2534
This code modifies the GitHub push action to verify that API v2 contains the model version that API v1 will be launched with; otherwise, deployment fails.
A previous attempt of this code ran into issues around installing
jq. Instead of using a Bash script, this code just runsapt-getinline in the GitHub Action based on advice here.