Skip to content

Ensure that when API v1 attempts deploy, API v2 runs with required model version#2547

Merged
anth-volk merged 6 commits into
masterfrom
fix/properly-install-jq
Jun 9, 2025
Merged

Ensure that when API v1 attempts deploy, API v2 runs with required model version#2547
anth-volk merged 6 commits into
masterfrom
fix/properly-install-jq

Conversation

@anth-volk

@anth-volk anth-volk commented Jun 6, 2025

Copy link
Copy Markdown
Collaborator

Fixes #2564
Redo of #2534

This code modifies the GitHub push action to verify that API v2 contains the model version that API v1 will be launched with; otherwise, deployment fails.

A previous attempt of this code ran into issues around installing jq. Instead of using a Bash script, this code just runs apt-get inline in the GitHub Action based on advice here.

@codecov

codecov Bot commented Jun 6, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.55%. Comparing base (8c17b22) to head (d79b3f2).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2547   +/-   ##
=======================================
  Coverage   63.55%   63.55%           
=======================================
  Files          56       56           
  Lines        2220     2220           
  Branches      296      296           
=======================================
  Hits         1411     1411           
  Misses        747      747           
  Partials       62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nikhilwoodruff

Copy link
Copy Markdown
Collaborator

Looks reasonable but can we get a PR test passing with this first

@anth-volk anth-volk force-pushed the fix/properly-install-jq branch from bc6c34d to fdf81e2 Compare June 9, 2025 22:14
@anth-volk anth-volk changed the title Run apt-get inline to fix jq install Ensure that when API v1 attempts deploy, API v2 runs with required model version Jun 9, 2025
@anth-volk

Copy link
Copy Markdown
Collaborator Author

An example of this script setup passing on PR available here.

@anth-volk anth-volk mentioned this pull request Jun 9, 2025

@mikesmit mikesmit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this moving.

@anth-volk anth-volk merged commit 6f74f64 into master Jun 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add GitHub Action to ensure that when API is updated, sim API is running off required model version

3 participants