Skip to content

Deprecate national-with-breakdowns dataset selectors#3726

Merged
anth-volk merged 5 commits into
masterfrom
feat/deprecate-national-with-breakdowns
Jul 7, 2026
Merged

Deprecate national-with-breakdowns dataset selectors#3726
anth-volk merged 5 commits into
masterfrom
feat/deprecate-national-with-breakdowns

Conversation

@anth-volk

@anth-volk anth-volk commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Fixes #3728.

Summary:

  • Makes include_district_breakdowns a deprecated no-op in API v1 routes.
  • Deprecates national-with-breakdowns, national-with-breakdowns-test, and national-with-datasets as no-op dataset aliases that normalize to default.
  • Bumps the economy-impact cache schema so old cached responses do not mask the new district payload shape.

Merge dependencies:

Follow-up:

Verification:

  • uv run ruff check on changed API v1 files
  • uv run pytest tests/unit/services/test_economy_service.py tests/unit/routes/test_economy_dataset_validation.py tests/to_refactor/python/test_economy_budget_window_routes.py -q

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.89%. Comparing base (446d995) to head (1735f68).
⚠️ Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3726      +/-   ##
==========================================
+ Coverage   79.72%   79.89%   +0.16%     
==========================================
  Files          70       70              
  Lines        4326     4332       +6     
  Branches      807      807              
==========================================
+ Hits         3449     3461      +12     
+ Misses        657      652       -5     
+ Partials      220      219       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anth-volk
anth-volk marked this pull request as ready for review July 7, 2026 14:42
@anth-volk
anth-volk merged commit 8ac6a79 into master Jul 7, 2026
10 checks passed
@anth-volk
anth-volk deleted the feat/deprecate-national-with-breakdowns branch July 7, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate district breakdown dataset selectors

1 participant