Skip to content

Commit 012268a

Browse files
authored
Merge pull request #857 from PolicyEngine/fix/tag-fix-part-3
Fix launch tag syntax
2 parents 56e586c + 3b06c96 commit 012268a

2 files changed

Lines changed: 9 additions & 4 deletions

File tree

.github/workflows/deploy-production.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ env:
1111
REGION: us-central1
1212
SERVICE_NAME: policyengine-household-api
1313
IMAGE_NAME: us-central1-docker.pkg.dev/policyengine-household-api/policyengine-household-api/policyengine-household-api
14-
PYTHON_VERSION: '3.12'
14+
PYTHON_VERSION: '312' # Cannot use . in Artifact Registry versions
15+
IMAGE_VERSION: python${{ env.PYTHON_VERSION }}-latest
1516

1617
jobs:
1718
lint-and-test:
@@ -94,7 +95,7 @@ jobs:
9495
tags: |
9596
type=sha,prefix=,suffix=
9697
type=raw,value=latest,enable={{is_default_branch}}
97-
type=raw,value=python${{ env.PYTHON_VERSION }}-latest,enable={{is_default_branch}}
98+
type=raw,value=${{ env.IMAGE_VERSION }},enable={{is_default_branch}}
9899
99100
- name: Build and push Docker image
100101
uses: docker/build-push-action@v5
@@ -142,7 +143,7 @@ jobs:
142143
- name: Deploy to App Engine
143144
env:
144145
IMAGE_NAME: ${{ env.IMAGE_NAME }}
145-
IMAGE_TAG: python${{ env.PYTHON_VERSION }}-latest
146+
IMAGE_TAG: ${{ env.IMAGE_VERSION }}
146147
SERVICE_ACCOUNT: github-deployment@policyengine-household-api.iam.gserviceaccount.com
147148
APP_YAML_PATH: ./gcp/policyengine_household_api/app.yaml
148149
AUTH0_ADDRESS_NO_DOMAIN: ${{ secrets.AUTH0_ADDRESS_NO_DOMAIN }}
@@ -156,7 +157,7 @@ jobs:
156157
- name: Set traffic to new version
157158
env:
158159
SERVICE_NAME: ${{ env.SERVICE_NAME }}
159-
VERSION: python${{ env.PYTHON_VERSION }}-latest
160+
VERSION: ${{ env.IMAGE_VERSION }}
160161
run: .github/scripts/set-traffic.sh
161162

162163
- name: Verify deployment

changelog_entry.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
- bump: patch
2+
changes:
3+
changed:
4+
- Fixed launch tag syntax

0 commit comments

Comments
 (0)