Clean up retired Modal apps by default

Author: anth-volk

.github/scripts/create_pr.sh

@@ -36,7 +36,7 @@ Related to #1178
 modal_release:
   new_app_target: frontier
   promote_existing_frontier: true
-  cleanup_target: none
+  cleanup_target: retired
 \`\`\`
 
 ## Version Updates

.github/scripts/test_resolve_modal_release_config.py

@@ -69,6 +69,7 @@ def test_resolve_release_uses_weekly_default_for_empty_workflow_dispatch():
     assert resolved.should_deploy is True
     assert resolved.source == "workflow-dispatch-inputs"
     assert resolved.config is not None
+    assert resolved.config.cleanup_target == "retired"
 
 
 def test_resolve_release_skips_regular_push_even_with_pr_config():
@@ -130,3 +131,5 @@ def test_resolve_release_uses_weekly_default_when_no_pr_body_exists():
 
     assert resolved.should_deploy is True
     assert resolved.source == "weekly-default"
+    assert resolved.config is not None
+    assert resolved.config.cleanup_target == "retired"

.github/workflows/deploy-staged.yml

@@ -23,7 +23,7 @@ on:
       cleanup_target:
         description: "Modal app group to stop after updating the manifest"
         required: true
-        default: none
+        default: retired
         type: choice
         options:
           - none

changelog.d/1525.changed.md

@@ -1 +1 @@
-Keep a small warm Modal worker pool for the production environment.
+Keep a small warm Modal worker pool for the production environment and clean up retired Modal worker apps by default.

docs/engineering/skills/modal-release-prs.md

@@ -19,7 +19,7 @@ block:
 modal_release:
   new_app_target: frontier
   promote_existing_frontier: true
-  cleanup_target: none
+  cleanup_target: retired
 ```
 
 Allowed values:
@@ -40,13 +40,15 @@ different deployment behavior:
 modal_release:
   new_app_target: frontier
   promote_existing_frontier: true
-  cleanup_target: none
+  cleanup_target: retired
 ```
 
 This deploys the new worker to `frontier`, promotes the previous `frontier` to
 `current`, and moves the previous `current` into the manifest's `retired`
-history. Retired apps are not deleted unless `cleanup_target: retired` is
-explicitly configured.
+history. The default weekly release shape uses `cleanup_target: retired`, so
+apps in the retired history are stopped after the manifest is updated. Use
+`cleanup_target: none` only when the user explicitly asks to preserve retired
+worker apps after release.
 
 Do not use PR labels, branch names, model-specific tags, or title prefixes to
 control Modal release behavior. The PR body YAML block is the source of truth.

policyengine_household_api/modal_release/release_config.py

@@ -116,7 +116,7 @@ def default_weekly_config() -> ModalReleaseConfig:
     return ModalReleaseConfig(
         new_app_target=NewAppTarget.FRONTIER,
         promote_existing_frontier=True,
-        cleanup_target=CleanupTarget.NONE,
+        cleanup_target=CleanupTarget.RETIRED,
     )