Skip to content

Commit 5859037

Browse files
committed
Remove pre-cutover custom domain smoke gate
1 parent e50edbb commit 5859037

5 files changed

Lines changed: 8 additions & 202 deletions

File tree

.github/scripts/modal-custom-domain-smoke.sh

Lines changed: 0 additions & 58 deletions
This file was deleted.

.github/scripts/test_modal_custom_domain_smoke.py

Lines changed: 0 additions & 141 deletions
This file was deleted.

.github/scripts/test_modal_deploy_release.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,13 @@ def test_modal_deploy_release_release_mode_updates_manifest_and_cleans(
9898
assert "cleanup-called" in log
9999

100100

101+
def test_deploy_workflow_does_not_smoke_custom_domain_before_cutover():
102+
workflow = Path(".github/workflows/deploy-staged.yml").read_text()
103+
104+
assert "modal-custom-domain-smoke.sh" not in workflow
105+
assert "Verify production custom domain" not in workflow
106+
107+
101108
def _deploy_env(tmp_path: Path, log_path: Path) -> dict[str, str]:
102109
sync_script = tmp_path / "sync-secrets.sh"
103110
sync_script.write_text("#!/usr/bin/env bash\nexit 0\n")

.github/workflows/deploy-staged.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -266,9 +266,6 @@ jobs:
266266
'${{ needs.resolve-modal-release-config.outputs.config_json }}' \
267267
'${{ needs.resolve-modal-release-config.outputs.deploy_mode }}'
268268
269-
- name: Verify production custom domain
270-
run: bash .github/scripts/modal-custom-domain-smoke.sh
271-
272269
publish:
273270
name: Publish to PyPI
274271
runs-on: ubuntu-latest

changelog.d/1539.fixed.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Remove the production custom-domain smoke gate from Modal deployment so code can deploy before DNS cutover.

0 commit comments

Comments
 (0)