Confirm Modal app cleanup in CI#1538
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1537
Summary
--yestomodal app stopduring Modal retired-app cleanup so GitHub Actions does not block on an interactive confirmation prompt.uv run modal app stop --yes --env ....Validation
uv run pytest .github/scripts/test_modal_cleanup_apps.pymake format-checkuv run pytest -vv --timeout=150 -rP .github/scripts tests/to_refactor tests/unitNote:
make testfailed locally before running tests because the non-uv pytest entrypoint did not havepytest-timeoutavailable for--timeout=150; the equivalent uv-backed command passed.make format-checkalso prints a Docker daemon warning from Makefile evaluation on this machine, then Ruff completes successfully.