Skip to content

Remove pre-cutover custom domain smoke gate#1540

Merged
anth-volk merged 1 commit into
mainfrom
codex/remove-custom-domain-smoke
May 18, 2026
Merged

Remove pre-cutover custom domain smoke gate#1540
anth-volk merged 1 commit into
mainfrom
codex/remove-custom-domain-smoke

Conversation

@anth-volk
Copy link
Copy Markdown
Collaborator

Fixes #1539

Summary

  • Remove the production custom-domain smoke step from deploy-staged so Modal code can deploy before DNS cutover.
  • Delete the dedicated custom-domain smoke script and its tests.
  • Add a regression test confirming the deploy workflow does not call the removed smoke gate.

The generated Modal gateway URL is still smoke-checked by modal-deploy-release.sh using /liveness_check; this only removes the household.api.policyengine.org gate.

Validation

  • uv run pytest .github/scripts/test_modal_deploy_release.py
  • make format-check
  • uv run pytest .github/scripts

Note: make format-check printed the existing local Docker daemon warning before completing Ruff format verification successfully.

@anth-volk anth-volk force-pushed the codex/remove-custom-domain-smoke branch from 5859037 to 0689bb6 Compare May 18, 2026 20:07
@anth-volk anth-volk marked this pull request as ready for review May 18, 2026 20:12
@anth-volk anth-volk merged commit 92e7cb8 into main May 18, 2026
5 checks passed
@anth-volk anth-volk deleted the codex/remove-custom-domain-smoke branch May 18, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove pre-cutover custom domain smoke gate from Modal deployment

1 participant