Skip to content

Fix Modal gateway routing metadata imports#1544

Merged
anth-volk merged 3 commits into
mainfrom
codex/fix-modal-gateway-routing-metadata-import
May 20, 2026
Merged

Fix Modal gateway routing metadata imports#1544
anth-volk merged 3 commits into
mainfrom
codex/fix-modal-gateway-routing-metadata-import

Conversation

@anth-volk
Copy link
Copy Markdown
Collaborator

@anth-volk anth-volk commented May 20, 2026

Fixes #1543

Summary

  • Moved Modal routing metadata helpers out of policyengine_household_api.utils and into policyengine_household_api.modal_release.
  • Updated gateway, worker dispatch, analytics, and related tests to import from the side-effect-free Modal release module.
  • Added an inline comment documenting why the gateway keeps channel values as a literal instead of importing the app enum.

Testing

  • uv run pytest tests/unit/modal_release/test_gateway.py tests/unit/modal_release/test_worker_dispatch.py -q
  • uv run pytest tests/unit/endpoints/test_household.py::TestCalculateEndpoint::test__analytics_enabled__captures_modal_routing_metadata -q
  • make format-check

Note: make format-check passed after printing the existing Docker daemon warning from Makefile variable expansion.

@anth-volk anth-volk marked this pull request as ready for review May 20, 2026 16:46
@anth-volk anth-volk merged commit dbe77d8 into main May 20, 2026
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Modal gateway import boundary for routing metadata

1 participant