Commit 817f777
/diagnose-issue: comment style guidance (question-shaped, link-heavy) (#898)
* /diagnose-issue: require full TAXSIM input mapping when using direct Simulation
Lesson from re-examining taxsim #882: forgetting to pass
tax_unit_childcare_expenses in a direct Simulation situation
zeroed the federal CDCC, which shifted tax_liability_if_not_itemizing
by ~$300 and made it look like Microsim and Simulation produced
different answers. They actually agreed — I was comparing apples to
oranges because the inputs weren't identical.
Step 6 now mandates a TAXSIM-to-PE variable cross-walk before running
a direct Simulation, with a table of the easy-to-miss mappings
(childcare → tax_unit_childcare_expenses, proptax → real_estate_taxes,
mortgage → deductible_mortgage_interest, rentpaid → rent).
Debugging checklist updated to match.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* /diagnose-issue Step 1: treat reporter's claims as hypothesis, verify against output.txt
If the reporter cites a specific PE value, confirm it appears in the
bundle's output.txt before building a diagnosis around it. Reporters
sometimes paste values from a different case; without this check
you can construct a wrong narrative around a wrong number.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* /diagnose-issue Step 9: comment style — question-shaped + link-heavy
Replies to taxsim issues should phrase findings as questions ("Possible
that...?") rather than pronouncements, always link the primary sources
used (statute URL, Rev. Proc. PDF, GitHub permalink to the relevant
PE-US variable), and anchor PE behavior to code rather than assertion.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 8a99769 commit 817f777
2 files changed
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
257 | 257 | | |
258 | 258 | | |
259 | 259 | | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
260 | 269 | | |
261 | 270 | | |
262 | 271 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
0 commit comments