#1051 changed scorp → partnership_s_corp_income, which reverted #1042 (scorp → s_corp_income, mapped to the dedicated S-corp leaf split out in pe-us #8613). #1051's rationale — "holding the leaf suppressed QBID" — only applied with the qualified_business_income holdout present, which #1051 itself removed.
Verified: once #1051's holdout fix is in place, scorp → s_corp_income yields the correct QBID (16,850, including the scorp + pbusinc case), with identical federal/CA/eCPS results. So the revert is unnecessary and mapping to the parent (partnership_s_corp_income) risks leaving the s_corp_income leaf unpopulated for any state calc that references it specifically.
Fix: map scorp → s_corp_income (one line in variable_mappings.yaml + the two mapper paths), restoring the #1042/#8613 coordination. Low priority — empirically harmless — but keeps the leaf correct. From the #1051 review.
#1051 changed
scorp → partnership_s_corp_income, which reverted #1042 (scorp → s_corp_income, mapped to the dedicated S-corp leaf split out in pe-us #8613). #1051's rationale — "holding the leaf suppressed QBID" — only applied with thequalified_business_incomeholdout present, which #1051 itself removed.Verified: once #1051's holdout fix is in place,
scorp → s_corp_incomeyields the correct QBID (16,850, including thescorp + pbusinccase), with identical federal/CA/eCPS results. So the revert is unnecessary and mapping to the parent (partnership_s_corp_income) risks leaving thes_corp_incomeleaf unpopulated for any state calc that references it specifically.Fix: map
scorp → s_corp_income(one line invariable_mappings.yaml+ the two mapper paths), restoring the #1042/#8613 coordination. Low priority — empirically harmless — but keeps the leaf correct. From the #1051 review.