Deflake the generate-phase performance test (floor timing denominator at 100ms)#1073
Merged
Merged
Conversation
test_generate_does_not_scale_linearly flaked twice this week (5.3x on windows-3.10, 5.9x on macos-3.10) with both absolute times under a quarter second, where scheduler noise dominates the ratio. Floor the denominator at 100ms; a real pathological regression still trips the assertion. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`test_generate_does_not_scale_linearly` flaked twice this week on unrelated PRs (#1070: 5.3x on windows-3.10; #1072: 5.9x on macos-3.10) — in both cases the absolute times were tiny (e.g. 0.03s → 0.20s), where scheduler noise dominates the ratio. Floor the denominator at 100ms so sub-noise bases can't fail the 5x assertion; a genuinely pathological regression (row-loop/quadratic) still trips it because the 500-record time grows into whole seconds.
🤖 Generated with Claude Code