Merge pull request #189 from PolicyEngine/custom-frs-fix

nikhilwoodruff · web-flow · commit 7d2e17365c2a · 2025-12-09T10:06:17.000Z
Fix bug in post-2023 FRS runs
diff --git a/changelog_entry.yaml b/changelog_entry.yaml
@@ -0,0 +1,4 @@
+- bump: patch
+  changes:
+    fixed:
+    - A bug hard-coded to 2023, which meant that custom FRS datasets defined after 2024 fail on BRMA imputation.
diff --git a/policyengine_uk_data/datasets/frs.py b/policyengine_uk_data/datasets/frs.py
@@ -774,7 +774,7 @@ def determine_education_level(fted_val, typeed2_val, age_val):
         {
             "brma": brma,
             "household_id": sim.populations["benunit"].household(
-                "household_id", 2023
+                "household_id", sim.dataset.time_period
             ),
         }
     )

Original file line number	Diff line number	Diff line change
`@@ -774,7 +774,7 @@ def determine_education_level(fted_val, typeed2_val, age_val):`
`774`	`774`	`{`
`775`	`775`	`"brma": brma,`
`776`	`776`	`"household_id": sim.populations["benunit"].household(`
`777`		`- "household_id", 2023`
	`777`	`+ "household_id", sim.dataset.time_period`
`778`	`778`	`),`
`779`	`779`	`}`
`780`	`780`	`)`