Commit e336692
Remove birth_year from FRS dataset generation
birth_year should be calculated from age and period in the model,
not stored as static data in the dataset. This allows birth_year to
properly update in multi-year projections.
With static birth_year in the dataset:
- 2026: birth_year stays 2006-2023 (based on 2023 survey)
- 2029: birth_year stays 2006-2023 (incorrect)
By calculating birth_year = period.year - age:
- 2026: birth_year becomes 2009-2026 (correct for 2026)
- 2029: birth_year becomes 2012-2029 (correct for 2029)
This fix is required for PolicyEngine/policyengine-uk#1352 to work
correctly and ensure two-child limit cost projections increase over
time as expected.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>1 parent b693e54 commit e336692
2 files changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
113 | | - | |
| 113 | + | |
| 114 | + | |
114 | 115 | | |
115 | 116 | | |
116 | 117 | | |
| |||
0 commit comments