Quick fix on SPI code

nikhilwoodruff · nikhilwoodruff · commit e8284bb0116b · 2025-10-09T17:52:13.000+01:00
diff --git a/policyengine_uk_data/datasets/spi.py b/policyengine_uk_data/datasets/spi.py
@@ -22,7 +22,7 @@ def create_spi(
     household["household_weight"] = df.FACT
     person["dividend_income"] = df.DIVIDENDS
     person["gift_aid"] = df.GIFTAID
-    person["region"] = (
+    household["region"] = (
         df.GORCODE.map(
             {
                 1: "NORTH_EAST",
@@ -39,9 +39,11 @@ def create_spi(
                 12: "NORTHERN_IRELAND",
             }
         )
-        .fillna("UNKNOWN")
-        .astype("S")
+        .fillna("SOUTH_EAST")
     )
+    household["rent"] = 0
+    household["tenure_type"] = "OWNED_OUTRIGHT"
+    household["council_tax"] = 0
     person["savings_interest_income"] = df.INCBBS
     person["property_income"] = df.INCPROP
     person["employment_income"] = df.PAY + df.EPB

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ def create_spi(`
`22`	`22`	`household["household_weight"] = df.FACT`
`23`	`23`	`person["dividend_income"] = df.DIVIDENDS`
`24`	`24`	`person["gift_aid"] = df.GIFTAID`
`25`		`- person["region"] = (`
	`25`	`+ household["region"] = (`
`26`	`26`	`df.GORCODE.map(`
`27`	`27`	`{`
`28`	`28`	`1: "NORTH_EAST",`
`@@ -39,9 +39,11 @@ def create_spi(`
`39`	`39`	`12: "NORTHERN_IRELAND",`
`40`	`40`	`}`
`41`	`41`	`)`
`42`		`- .fillna("UNKNOWN")`
`43`		`- .astype("S")`
	`42`	`+ .fillna("SOUTH_EAST")`
`44`	`43`	`)`
	`44`	`+ household["rent"] = 0`
	`45`	`+ household["tenure_type"] = "OWNED_OUTRIGHT"`
	`46`	`+ household["council_tax"] = 0`
`45`	`47`	`person["savings_interest_income"] = df.INCBBS`
`46`	`48`	`person["property_income"] = df.INCPROP`
`47`	`49`	`person["employment_income"] = df.PAY + df.EPB`