Skip to content

Fix SSMG uprating #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikhilwoodruff merged 7 commits into from
Jul 10, 2025
Merged

Fix SSMG uprating #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9bce4f2
Fix SSMG uprating
nikhilwoodruff Jul 10, 2025
3995ec6
Remove change
nikhilwoodruff Jul 10, 2025
6f1844d
Add safety check to cg imputation
nikhilwoodruff Jul 10, 2025
c36cff3
Print
nikhilwoodruff Jul 10, 2025
08cdfaf
Try this??
nikhilwoodruff Jul 10, 2025
43c9c0a
Correctly cast data type
nikhilwoodruff Jul 10, 2025
523e48d
Add student loan repayments
nikhilwoodruff Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog_entry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- bump: patch
changes:
fixed:
- SSMG uprating.
2 changes: 2 additions & 0 deletions policyengine_uk_data/datasets/frs/frs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,8 @@ def add_market_income(

frs["lump_sum_income"] = person.REDAMT

frs["student_loan_repayments"] = person.SLREPAMT * 52


def sum_from_positive_fields(
table: pd.DataFrame, fields: List[str]
Expand Down
4 changes: 2 additions & 2 deletions policyengine_uk_data/utils/imputations/capital_gains.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ def loss(blend_factor):
lower = row.minimum_total_income
upper = row.maximum_total_income
ti_in_range = (ti >= lower) * (ti < upper)
in_target_range = has_cg * ti_in_range
quantiles = np.random.random(int(in_target_range.sum()))
in_target_range = has_cg * ti_in_range > 0
quantiles = np.random.random(int(in_target_range.values.sum()))
pred_capital_gains = spline(quantiles)
new_cg[in_target_range] = pred_capital_gains

Expand Down
Loading