Skip to content

Fix bug in post-2023 FRS runs #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nwoodruff-co merged 2 commits into from
Dec 9, 2025
Merged

Fix bug in post-2023 FRS runs #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4846c03
Fix bug
nikhilwoodruff Sep 9, 2025
9a5012c
Changelog
nikhilwoodruff Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog_entry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
- bump: patch
changes:
fixed:
- A bug hard-coded to 2023, which meant that custom FRS datasets defined after 2024 fail on BRMA imputation.
2 changes: 1 addition & 1 deletion policyengine_uk_data/datasets/frs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ def determine_education_level(fted_val, typeed2_val, age_val):
{
"brma": brma,
"household_id": sim.populations["benunit"].household(
"household_id", 2023
"household_id", sim.dataset.time_period
),
}
)
Expand Down