Skip to content

Commit 28c3f6c

Browse files
vahid-ahmadiclaude
andauthored
Test parameter description punctuation, fix 178 violations (#340) (#1664)
Adds `policyengine_uk/tests/test_parameter_descriptions.py` which asserts every parameter `description` ends with a period — and brings the existing 178 parameter files into compliance. Multi-line descriptions are handled by appending the period to the last continuation line so the sentence ends correctly when YAML joins them. Per #339, these descriptions surface in the UI and were inconsistent; locking the convention in CI prevents drift going forward. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent fb34a52 commit 28c3f6c

180 files changed

Lines changed: 224 additions & 178 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

changelog.d/340.md

Lines changed: 1 addition & 0 deletions

policyengine_uk/parameters/gov/benefit_uprating_cpi.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
description: Most recent September CPIH index value, updated for each uprating occurrence (2005=100)
1+
description: Most recent September CPIH index value, updated for each uprating occurrence (2005=100).
22
values:
33
2005-01-01: 100
44
2010-01-01: 114.48

policyengine_uk/parameters/gov/boe/base_rate.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
description: Bank of England base rate
1+
description: Bank of England base rate.
22
metadata:
33
label: BoE base rate
44
unit: /1

policyengine_uk/parameters/gov/dfe/adult_dependants_grant/income_limit.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
description: Household income limit for Adult Dependants' Grant
1+
description: Household income limit for Adult Dependants' Grant.
22
metadata:
33
label: Adult Dependants' Grant household income limit
44
unit: currency-GBP

policyengine_uk/parameters/gov/dfe/adult_dependants_grant/maximum.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
description: Maximum Adult Dependants' Grant amount
1+
description: Maximum Adult Dependants' Grant amount.
22
metadata:
33
label: Adult Dependants' Grant maximum
44
unit: currency-GBP

policyengine_uk/parameters/gov/dfe/adult_dependants_grant/other_adult_income_limit.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
description: Income limit for a non-partner adult dependant in the Adult Dependants' Grant assessment
1+
description: Income limit for a non-partner adult dependant in the Adult Dependants' Grant assessment.
22
metadata:
33
label: Adult Dependants' Grant other adult income limit
44
unit: currency-GBP

policyengine_uk/parameters/gov/dwp/ESA/eligibility/min_age.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
description: Minimum age for Employment and Support Allowance
1+
description: Minimum age for Employment and Support Allowance.
22
metadata:
33
unit: year
44
period: year

policyengine_uk/parameters/gov/dwp/ESA/income/amount_18_24.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
description: Income-based Employment and Support Allowance personal allowance for
2-
persons aged 18-24
2+
persons aged 18-24.
33
metadata:
44
economy: false
55
period: week

policyengine_uk/parameters/gov/dwp/ESA/income/amount_over_25.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
description: Income-based Employment and Support Allowance personal allowance for
2-
persons aged over 25
2+
persons aged over 25.
33
metadata:
44
economy: false
55
period: week

policyengine_uk/parameters/gov/dwp/ESA/income/couple.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
description: Income-based Employment and Support Allowance personal allowance for
2-
couples
2+
couples.
33
metadata:
44
economy: false
55
period: week

0 commit comments

Comments
 (0)